Re: Review Request 45937: Support Atlas / Storm integration

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45937/#review127875
---


Ship it!




Ship It!

- Robert Levas


On April 8, 2016, 4:09 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45937/
> ---
> 
> (Updated April 8, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Levas.
> 
> 
> Bugs: AMBARI-14920
> https://issues.apache.org/jira/browse/AMBARI-14920
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update configurations and copy required libraries.
> 
> 1 In storm.yaml:
> - storm.topology.submission.notifier.plugin.class: 
> "org.apache.atlas.storm.hook.StormAtlasHook"
> - atlas.cluster.name: "cluster_name"
> 
> 2 In storm_env.ini:
> - STORM_JAR_JVM_OPTS:"-Datlas.conf=$ATLAS_HOME/conf/"
> 
> 3 cp $ATLAS_PACKAGE/hook/storm/*.jar to $STORM_HOME/extlib (or symlink'd)
> 
> 
> Also documented here: 
> https://github.com/apache/incubator-atlas/blob/master/docs/src/site/twiki/StormAtlasHook.twiki
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
>  aada363 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
>  e9e8ce5 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
>  d2fafa6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-env.xml
>  2bb0862 
> 
> Diff: https://reviews.apache.org/r/45937/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 45937: Support Atlas / Storm integration

[Tom Beerbower]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45937/
---

(Updated April 8, 2016, 8:09 p.m.)


Review request for Ambari, John Speidel and Robert Levas.


Changes
---

updated diff


Bugs: AMBARI-14920
https://issues.apache.org/jira/browse/AMBARI-14920


Repository: ambari


Description
---

Update configurations and copy required libraries.

1 In storm.yaml:
- storm.topology.submission.notifier.plugin.class: 
"org.apache.atlas.storm.hook.StormAtlasHook"
- atlas.cluster.name: "cluster_name"

2 In storm_env.ini:
- STORM_JAR_JVM_OPTS:"-Datlas.conf=$ATLAS_HOME/conf/"

3 cp $ATLAS_PACKAGE/hook/storm/*.jar to $STORM_HOME/extlib (or symlink'd)


Also documented here: 
https://github.com/apache/incubator-atlas/blob/master/docs/src/site/twiki/StormAtlasHook.twiki


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
 aada363 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
 e9e8ce5 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
 d2fafa6 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-env.xml
 2bb0862 

Diff: https://reviews.apache.org/r/45937/diff/


Testing
---

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 45937: Support Atlas / Storm integration

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45937/#review127853
---




ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
 (line 195)


Please dont use "/usr/hdp" hardcoded stack_root folder. Use "stack_root" 
variable instead. See line#44 in this file.


- Jayush Luniya


On April 8, 2016, 6:36 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45937/
> ---
> 
> (Updated April 8, 2016, 6:36 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Robert Levas.
> 
> 
> Bugs: AMBARI-14920
> https://issues.apache.org/jira/browse/AMBARI-14920
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update configurations and copy required libraries.
> 
> 1 In storm.yaml:
> - storm.topology.submission.notifier.plugin.class: 
> "org.apache.atlas.storm.hook.StormAtlasHook"
> - atlas.cluster.name: "cluster_name"
> 
> 2 In storm_env.ini:
> - STORM_JAR_JVM_OPTS:"-Datlas.conf=$ATLAS_HOME/conf/"
> 
> 3 cp $ATLAS_PACKAGE/hook/storm/*.jar to $STORM_HOME/extlib (or symlink'd)
> 
> 
> Also documented here: 
> https://github.com/apache/incubator-atlas/blob/master/docs/src/site/twiki/StormAtlasHook.twiki
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
>  aada363 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
>  e9e8ce5 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
>  d2fafa6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-env.xml
>  2bb0862 
> 
> Diff: https://reviews.apache.org/r/45937/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>