Re: Review Request 46001: Exception seen in ambari-agent during restart.

2016-04-11 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46001/#review128240
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 11, 2016, 4:52 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46001/
> ---
> 
> (Updated April 11, 2016, 4:52 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15796
> https://issues.apache.org/jira/browse/AMBARI-15796
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> agent restart  
> Restarting ambari-agent  
> Verifying Python version compatibility...  
> Using python /usr/bin/python  
> Found ambari-agent PID: 9941  
> Stopping ambari-agent  
> *Traceback (most recent call last):  
> File "/usr/lib/python2.6/site-packages/ambari_agent/main.py", line 343, in
>   
> logger.exception("Exiting with exception:" + e)  
> TypeError: cannot concatenate 'str' and 'exceptions.Exception' objects*  
> Removing PID file at /var/run/ambari-agent/ambari-agent.pid
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/main.py b146ba8 
> 
> Diff: https://reviews.apache.org/r/46001/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Re: Review Request 46001: Exception seen in ambari-agent during restart.

2016-04-11 Thread Andrew Onischuk


> On April 11, 2016, 6:30 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/main.py, line 318
> > 
> >
> > Why not print str(e)

Logger.exception add message and stacktrace itself.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46001/#review128194
---


On April 11, 2016, 4:52 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46001/
> ---
> 
> (Updated April 11, 2016, 4:52 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15796
> https://issues.apache.org/jira/browse/AMBARI-15796
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> agent restart  
> Restarting ambari-agent  
> Verifying Python version compatibility...  
> Using python /usr/bin/python  
> Found ambari-agent PID: 9941  
> Stopping ambari-agent  
> *Traceback (most recent call last):  
> File "/usr/lib/python2.6/site-packages/ambari_agent/main.py", line 343, in
>   
> logger.exception("Exiting with exception:" + e)  
> TypeError: cannot concatenate 'str' and 'exceptions.Exception' objects*  
> Removing PID file at /var/run/ambari-agent/ambari-agent.pid
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/main.py b146ba8 
> 
> Diff: https://reviews.apache.org/r/46001/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Re: Review Request 46001: Exception seen in ambari-agent during restart.

2016-04-11 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46001/#review128194
---




ambari-agent/src/main/python/ambari_agent/main.py (line 318)


Why not print str(e)


- Alejandro Fernandez


On April 11, 2016, 4:52 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46001/
> ---
> 
> (Updated April 11, 2016, 4:52 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15796
> https://issues.apache.org/jira/browse/AMBARI-15796
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> agent restart  
> Restarting ambari-agent  
> Verifying Python version compatibility...  
> Using python /usr/bin/python  
> Found ambari-agent PID: 9941  
> Stopping ambari-agent  
> *Traceback (most recent call last):  
> File "/usr/lib/python2.6/site-packages/ambari_agent/main.py", line 343, in
>   
> logger.exception("Exiting with exception:" + e)  
> TypeError: cannot concatenate 'str' and 'exceptions.Exception' objects*  
> Removing PID file at /var/run/ambari-agent/ambari-agent.pid
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/main.py b146ba8 
> 
> Diff: https://reviews.apache.org/r/46001/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>