Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46198/ --- (Updated April 14, 2016, 3:19 p.m.) Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-15882 https://issues.apache.org/jira/browse/AMBARI-15882 Repository: ambari Description --- Properties defined in external stack definition were excluded in case of bp deployments. (eg. : oozie-site.xml from the falcon stack definition) Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 1433a1b ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 834953b Diff: https://reviews.apache.org/r/46198/diff/ Testing (updated) --- Unit test done. Tests ran successfully. Manually tested on local / openstack cluster. Java Results : Tests run: 4226, Failures: 0, Errors: 0, Skipped: 32 Python: Total run:959 Total errors:0 Total failures:0 OK Thanks, Laszlo Puskas
Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46198/ --- (Updated April 14, 2016, 3:16 p.m.) Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- Testing OK Bugs: AMBARI-15882 https://issues.apache.org/jira/browse/AMBARI-15882 Repository: ambari Description --- Properties defined in external stack definition were excluded in case of bp deployments. (eg. : oozie-site.xml from the falcon stack definition) Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 1433a1b ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 834953b Diff: https://reviews.apache.org/r/46198/diff/ Testing (updated) --- Unit test done. Tests ran successfully. Manually tested on local / openstack cluster. Thanks, Laszlo Puskas
Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46198/#review128895 --- Ship it! Ship It! - Sebastian Toader On April 14, 2016, 2:27 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46198/ > --- > > (Updated April 14, 2016, 2:27 p.m.) > > > Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-15882 > https://issues.apache.org/jira/browse/AMBARI-15882 > > > Repository: ambari > > > Description > --- > > Properties defined in external stack definition were excluded in case of bp > deployments. > (eg. : oozie-site.xml from the falcon stack definition) > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 1433a1b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 834953b > > Diff: https://reviews.apache.org/r/46198/diff/ > > > Testing > --- > > Unit test done. (mvn test underway) > Manually tested on local / openstack cluster. > > > Thanks, > > Laszlo Puskas > >
Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46198/#review128893 --- Ship it! Ship It! - Robert Levas On April 14, 2016, 8:27 a.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46198/ > --- > > (Updated April 14, 2016, 8:27 a.m.) > > > Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-15882 > https://issues.apache.org/jira/browse/AMBARI-15882 > > > Repository: ambari > > > Description > --- > > Properties defined in external stack definition were excluded in case of bp > deployments. > (eg. : oozie-site.xml from the falcon stack definition) > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 1433a1b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 834953b > > Diff: https://reviews.apache.org/r/46198/diff/ > > > Testing > --- > > Unit test done. (mvn test underway) > Manually tested on local / openstack cluster. > > > Thanks, > > Laszlo Puskas > >
Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46198/#review128892 --- Ship it! Ship It! - Sandor Magyari On April 14, 2016, 12:27 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46198/ > --- > > (Updated April 14, 2016, 12:27 p.m.) > > > Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-15882 > https://issues.apache.org/jira/browse/AMBARI-15882 > > > Repository: ambari > > > Description > --- > > Properties defined in external stack definition were excluded in case of bp > deployments. > (eg. : oozie-site.xml from the falcon stack definition) > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 1433a1b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 834953b > > Diff: https://reviews.apache.org/r/46198/diff/ > > > Testing > --- > > Unit test done. (mvn test underway) > Manually tested on local / openstack cluster. > > > Thanks, > > Laszlo Puskas > >
Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46198/#review128886 --- Ship it! Ship It! - Robert Nettleton On April 14, 2016, 12:27 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46198/ > --- > > (Updated April 14, 2016, 12:27 p.m.) > > > Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-15882 > https://issues.apache.org/jira/browse/AMBARI-15882 > > > Repository: ambari > > > Description > --- > > Properties defined in external stack definition were excluded in case of bp > deployments. > (eg. : oozie-site.xml from the falcon stack definition) > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 1433a1b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 834953b > > Diff: https://reviews.apache.org/r/46198/diff/ > > > Testing > --- > > Unit test done. (mvn test underway) > Manually tested on local / openstack cluster. > > > Thanks, > > Laszlo Puskas > >