Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

2016-04-14 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128996
---


Ship it!




Ship It!

- Jaimin Jetly


On April 14, 2016, 8:56 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> ---
> 
> (Updated April 14, 2016, 8:56 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
> Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15892
> https://issues.apache.org/jira/browse/AMBARI-15892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the 
> computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
> 
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
> lead to a double subtraction of mem_cached, thereby leading to a negative 
> value intermittently.
> 
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  0476326 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 0f8f105 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> a19a112 
> 
> Diff: https://reviews.apache.org/r/46219/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> 
> Manual widget testing done.
> 
> Manual upgrade testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

2016-04-14 Thread Aravindan Vijayan 


> On April 14, 2016, 8:28 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json,
> >  lines 201-205
> > 
> >
> > Lets remove this mem_cached entry if it is not being used as part of 
> > the equation of the Memory Utlization. Otherwise UI will keep polling for 
> > it even if it is now not being used in the formula

Fixed the issue. Can you mark Ship It if the changes look ok?


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128977
---


On April 14, 2016, 8:56 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> ---
> 
> (Updated April 14, 2016, 8:56 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
> Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15892
> https://issues.apache.org/jira/browse/AMBARI-15892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the 
> computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
> 
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
> lead to a double subtraction of mem_cached, thereby leading to a negative 
> value intermittently.
> 
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  0476326 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 0f8f105 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> a19a112 
> 
> Diff: https://reviews.apache.org/r/46219/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> 
> Manual widget testing done.
> 
> Manual upgrade testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

2016-04-14 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/
---

(Updated April 14, 2016, 8:56 p.m.)


Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
Mohanty, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-15892
https://issues.apache.org/jira/browse/AMBARI-15892


Repository: ambari


Description
---

Issue
In the "NameNode HostLoad" graph, the negative values are seen for the computed 
metric "Memory Utilization" which goes by the formula :
( mem_total - (mem_free + mem_cache) ) *100 / mem_total

Bug
AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
lead to a double subtraction of mem_cached, thereby leading to a negative value 
intermittently.

Fix
Change the widget to :
( mem_total - mem_free ) *100 / mem_total


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
 0476326 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
0f8f105 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
a19a112 

Diff: https://reviews.apache.org/r/46219/diff/


Testing (updated)
---

Unit tests pass. 

Manual widget testing done.

Manual upgrade testing done.


Thanks,

Aravindan Vijayan

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

2016-04-14 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128977
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
(lines 201 - 205)


Lets remove this mem_cached entry if it is not being used as part of the 
equation of the Memory Utlization. Otherwise UI will keep polling for it even 
if it is now not being used in the formula


- Jaimin Jetly


On April 14, 2016, 7:40 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> ---
> 
> (Updated April 14, 2016, 7:40 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
> Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15892
> https://issues.apache.org/jira/browse/AMBARI-15892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the 
> computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
> 
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
> lead to a double subtraction of mem_cached, thereby leading to a negative 
> value intermittently.
> 
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  0476326 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 0f8f105 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> a19a112 
> 
> Diff: https://reviews.apache.org/r/46219/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> 
> Manual widget testing done.
> 
> Manual upgrade testing pending.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

2016-04-14 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128967
---


Ship it!




Ship It!

- Sid Wagle


On April 14, 2016, 7:40 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> ---
> 
> (Updated April 14, 2016, 7:40 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
> Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15892
> https://issues.apache.org/jira/browse/AMBARI-15892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the 
> computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
> 
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
> lead to a double subtraction of mem_cached, thereby leading to a negative 
> value intermittently.
> 
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  0476326 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 0f8f105 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> a19a112 
> 
> Diff: https://reviews.apache.org/r/46219/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> 
> Manual widget testing done.
> 
> Manual upgrade testing pending.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>