Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129445 --- Ship it! Ship It! - Sid Wagle On April 18, 2016, 10:24

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129444 --- Ship it! Looks good to me. - Aravindan Vijayan On April 18,

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Jian He
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/ --- (Updated April 18, 2016, 10:24 p.m.) Review request for Ambari, Aravindan

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Jian He
> On April 18, 2016, 8:19 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java, > > line 280 > > > > > >

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Jian He
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/ --- (Updated April 18, 2016, 10:20 p.m.) Review request for Ambari, Aravindan

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129425 ---

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
> On April 18, 2016, 8:19 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java, > > line 57 > >

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

2016-04-18 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129418 ---