Re: Review Request 46543: After HSI is enabled in install wizard the validation call does not send HSI in the component list of the host_group resulting in validation errors

2016-04-21 Thread Yusaku Sako

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46543/#review129975
---


Ship it!




Ship It!

- Yusaku Sako


On April 21, 2016, 10:39 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46543/
> ---
> 
> (Updated April 21, 2016, 10:39 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15997
> https://issues.apache.org/jira/browse/AMBARI-15997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validation API call made on leaving "Configure Services" page needs to 
> include HIVE_INTERACTIVE_SERVER in the host component layout if enable 
> inetarctive query is selected to be true.
> Validation API call made in an installed cluster on saving configuration must 
> add/delete HIVE_INTERACTIVE_SERVER if user has enable/disable interactive 
> query
> 
> 
> Diffs
> -
> 
>   ambari-web/app/app.js 5fa4448 
>   ambari-web/app/controllers/installer.js 9c92282 
>   ambari-web/app/controllers/main/service/info/configs.js b589040 
>   ambari-web/app/controllers/main/service/item.js b1ea523 
>   ambari-web/app/controllers/wizard/step6_controller.js ff8f36a 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 196932d 
>   ambari-web/app/mixins/common/serverValidator.js fca1550 
>   ambari-web/app/utils/blueprint.js 30e69af 
>   ambari-web/app/views/common/configs/widgets/config_widget_view.js 1078386 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> 2d467c2 
> 
> Diff: https://reviews.apache.org/r/46543/diff/
> 
> 
> Testing
> ---
> 
> Verified manually that the patch fixes the issue
> Verified that ambari-web unit tests works with the patch:
> 
>   27517 tests complete (31 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>



Re: Review Request 46543: After HSI is enabled in install wizard the validation call does not send HSI in the component list of the host_group resulting in validation errors

2016-04-21 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46543/
---

(Updated April 21, 2016, 10:39 p.m.)


Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-15997
https://issues.apache.org/jira/browse/AMBARI-15997


Repository: ambari


Description (updated)
---

Validation API call made on leaving "Configure Services" page needs to include 
HIVE_INTERACTIVE_SERVER in the host component layout if enable inetarctive 
query is selected to be true.
Validation API call made in an installed cluster on saving configuration must 
add/delete HIVE_INTERACTIVE_SERVER if user has enable/disable interactive query


Diffs
-

  ambari-web/app/app.js 5fa4448 
  ambari-web/app/controllers/installer.js 9c92282 
  ambari-web/app/controllers/main/service/info/configs.js b589040 
  ambari-web/app/controllers/main/service/item.js b1ea523 
  ambari-web/app/controllers/wizard/step6_controller.js ff8f36a 
  ambari-web/app/controllers/wizard/step7/assign_master_controller.js 196932d 
  ambari-web/app/mixins/common/serverValidator.js fca1550 
  ambari-web/app/utils/blueprint.js 30e69af 
  ambari-web/app/views/common/configs/widgets/config_widget_view.js 1078386 
  ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
2d467c2 

Diff: https://reviews.apache.org/r/46543/diff/


Testing
---

Verified manually that the patch fixes the issue
Verified that ambari-web unit tests works with the patch:

  27517 tests complete (31 seconds)
  154 tests pending


Thanks,

Jaimin Jetly