Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-05-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/#review133132 --- Ship it! Ship It! - Sumit Mohanty On May 13, 2016, 3:25

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-05-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/ --- (Updated May 13, 2016, 11:25 a.m.) Review request for Ambari, Aravindan

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-23 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/ --- (Updated April 23, 2016, 11:22 a.m.) Review request for Ambari, Aravindan

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-22 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/#review130241 --- Ship it! Ship It! - Sumit Mohanty On April 22, 2016, 9:12

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-22 Thread Robert Levas
> On April 22, 2016, 4:58 p.m., Aravindan Vijayan wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, > > line 2433 > > > > > > I meant this method. > > Robert

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-22 Thread Aravindan Vijayan
> On April 22, 2016, 8:58 p.m., Aravindan Vijayan wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, > > line 2433 > > > > > > I meant this method. > > Robert

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-22 Thread Robert Levas
> On April 22, 2016, 4:58 p.m., Aravindan Vijayan wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, > > line 2433 > > > > > > I meant this method. I did a bit of

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-22 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/#review130178 ---

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

2016-04-22 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/#review130176 --- Ship it! This looks like a general utility method. Can we