Re: Review Request 46592: Add a quick link to Grafana dashboards from Hive Service page

2016-04-25 Thread Di Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46592/#review130394
---


Ship it!




Ship It!

- Di Li


On April 22, 2016, 11:17 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46592/
> ---
> 
> (Updated April 22, 2016, 11:17 p.m.)
> 
> 
> Review request for Ambari, Di Li, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16076
> https://issues.apache.org/jira/browse/AMBARI-16076
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Hive Dashboard (Grafana) link in Hive service page->Quick links Action
> 
> At present, All quick links of a service are mapped to only one master 
> component of the service. Also this mapping is done in FE. As part of this 
> task the mapping of a link to a master component is now done in quick link 
> stack definition. So we can now have quick links on a service page linking to 
> different component hosts driven from stack. If host component is not yet 
> installed on the cluster then quick link won't appear.
> 
> Also seperate protocol defination can be made for every single quick link.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  8800b3a 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/quicklinks/quicklinks.json
>  1c276c0 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
>  48a3efe 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/quicklinks/quicklinks.json
>  b6281f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json
>  621fe8a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks/quicklinks.json
>  56c54b8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/quicklinks/quicklinks.json
>  42611d6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/quicklinks/quicklinks.json
>  36e67c2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json
>  37e95cf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
>  9863dc4 
>   ambari-web/app/controllers/wizard/step6_controller.js 3adc636 
>   ambari-web/app/controllers/wizard/step7_controller.js 2f78adf 
>   ambari-web/app/models/quicklinks/quick_links_config.js c9b2709 
>   ambari-web/app/views/common/quick_view_link_view.js dcaacb8 
>   ambari-web/test/views/common/quick_link_view_test.js 32b050b 
> 
> Diff: https://reviews.apache.org/r/46592/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on the cluster.
> Verified all ambari-web unit tests passes:
> 
>   27527 tests complete (31 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>



Re: Review Request 46592: Add a quick link to Grafana dashboards from Hive Service page

2016-04-22 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46592/
---

(Updated April 22, 2016, 11:17 p.m.)


Review request for Ambari, Di Li, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-16076
https://issues.apache.org/jira/browse/AMBARI-16076


Repository: ambari


Description
---

Add Hive Dashboard (Grafana) link in Hive service page->Quick links Action

At present, All quick links of a service are mapped to only one master 
component of the service. Also this mapping is done in FE. As part of this task 
the mapping of a link to a master component is now done in quick link stack 
definition. So we can now have quick links on a service page linking to 
different component hosts driven from stack. If host component is not yet 
installed on the cluster then quick link won't appear.

Also seperate protocol defination can be made for every single quick link.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
8800b3a 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/quicklinks/quicklinks.json
 1c276c0 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
 48a3efe 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/quicklinks/quicklinks.json
 b6281f7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/quicklinks/quicklinks.json
 5568122 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/quicklinks/quicklinks.json
 a4216e3 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json
 621fe8a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks-mapred/quicklinks.json
 36f71b5 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks/quicklinks.json
 56c54b8 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/quicklinks/quicklinks.json
 42611d6 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/quicklinks/quicklinks.json
 36e67c2 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json
 37e95cf 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
 9863dc4 
  ambari-web/app/controllers/wizard/step6_controller.js 3adc636 
  ambari-web/app/controllers/wizard/step7_controller.js 2f78adf 
  ambari-web/app/models/quicklinks/quick_links_config.js c9b2709 
  ambari-web/app/views/common/quick_view_link_view.js dcaacb8 
  ambari-web/test/views/common/quick_link_view_test.js 32b050b 

Diff: https://reviews.apache.org/r/46592/diff/


Testing (updated)
---

Manually tested on the cluster.
Verified all ambari-web unit tests passes:

  27527 tests complete (31 seconds)
  154 tests pending


Thanks,

Jaimin Jetly