Re: Review Request 46770: Capacity Scheduler View: New UI - queues save integration

2016-05-09 Thread Akhil PB 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46770/
---

(Updated May 9, 2016, 6:37 a.m.)


Review request for Ambari and Sreenath Somarajapuram.


Changes
---

Updated patch with comments


Bugs: AMBARI-15877
https://issues.apache.org/jira/browse/AMBARI-15877


Repository: ambari


Description
---

CapSched View: Queues save integration in new UI


Diffs (updated)
-

  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 0f4d038 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
 753fa9b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 8e278f0 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 f25180f 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 b5c3c04 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
 2628553 

Diff: https://reviews.apache.org/r/46770/diff/


Testing
---

Manual Unit Testing


Thanks,

Akhil PB

Re: Review Request 46770: Capacity Scheduler View: New UI - queues save integration

2016-05-05 Thread Sreenath Somarajapuram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46770/#review131811
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 34)


Are we using _this, else can we remove.



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 (line 21)


Can we get this removed?


- Sreenath Somarajapuram


On April 28, 2016, 11:43 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46770/
> ---
> 
> (Updated April 28, 2016, 11:43 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15877
> https://issues.apache.org/jira/browse/AMBARI-15877
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> CapSched View: Queues save integration in new UI
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  0f4d038 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  753fa9b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  8e278f0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  f25180f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  24f6938 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  b5c3c04 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  2628553 
> 
> Diff: https://reviews.apache.org/r/46770/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>