Re: Review Request 46800: HAWQ Configuration should be updated whenever Namenode is being moved.

2016-04-29 Thread jun aoki 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46800/#review131186
---


Ship it!




Ship It!

- jun aoki


On April 29, 2016, 8:46 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46800/
> ---
> 
> (Updated April 29, 2016, 8:46 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, Oleksandr 
> Diachenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-16172
> https://issues.apache.org/jira/browse/AMBARI-16172
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ Configuration should be updated whenever Namenode is being moved using 
> the move namenode wizard.
> Parameters which should be updated
> Case 1: HDFS HA
> hdfs-client parameters under HAWQ service
> dfs.namenode.rpc-address..
> dfs.namenode.http-address..
> Case 2: Non HA HDFS
> hawq-site parmeters under HAWQ service
> hawq_dfs_url
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 840bda3 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 1e137ee 
> 
> Diff: https://reviews.apache.org/r/46800/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
>   10505 tests complete (13 seconds)
>   121 tests pending
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 29.607 s
> [INFO] Finished at: 2016-04-28T14:53:42-07:00
> [INFO] Final Memory: 11M/213M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 46800: HAWQ Configuration should be updated whenever Namenode is being moved.

2016-04-29 Thread Alexander Denissov 


> On April 29, 2016, 8:59 p.m., Alexander Denissov wrote:
> > Ship It!

Do we also need to move PXF to the new namenode host ?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46800/#review131181
---


On April 29, 2016, 8:46 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46800/
> ---
> 
> (Updated April 29, 2016, 8:46 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, Oleksandr 
> Diachenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-16172
> https://issues.apache.org/jira/browse/AMBARI-16172
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ Configuration should be updated whenever Namenode is being moved using 
> the move namenode wizard.
> Parameters which should be updated
> Case 1: HDFS HA
> hdfs-client parameters under HAWQ service
> dfs.namenode.rpc-address..
> dfs.namenode.http-address..
> Case 2: Non HA HDFS
> hawq-site parmeters under HAWQ service
> hawq_dfs_url
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 840bda3 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 1e137ee 
> 
> Diff: https://reviews.apache.org/r/46800/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
>   10505 tests complete (13 seconds)
>   121 tests pending
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 29.607 s
> [INFO] Finished at: 2016-04-28T14:53:42-07:00
> [INFO] Final Memory: 11M/213M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 46800: HAWQ Configuration should be updated whenever Namenode is being moved.

2016-04-29 Thread bhuvnesh chaudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46800/
---

(Updated April 29, 2016, 8:46 p.m.)


Review request for Ambari, Alexander Denissov, jun aoki, Matt, Oleksandr 
Diachenko, and Richard Zang.


Changes
---

Applied feedback


Bugs: AMBARI-16172
https://issues.apache.org/jira/browse/AMBARI-16172


Repository: ambari


Description
---

HAWQ Configuration should be updated whenever Namenode is being moved using the 
move namenode wizard.
Parameters which should be updated
Case 1: HDFS HA
hdfs-client parameters under HAWQ service
dfs.namenode.rpc-address..
dfs.namenode.http-address..
Case 2: Non HA HDFS
hawq-site parmeters under HAWQ service
hawq_dfs_url


Diffs (updated)
-

  ambari-web/app/controllers/main/service/reassign/step4_controller.js 840bda3 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
1e137ee 

Diff: https://reviews.apache.org/r/46800/diff/


Testing
---

yes.

  10505 tests complete (13 seconds)
  121 tests pending

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 29.607 s
[INFO] Finished at: 2016-04-28T14:53:42-07:00
[INFO] Final Memory: 11M/213M


Thanks,

bhuvnesh chaudhary

Re: Review Request 46800: HAWQ Configuration should be updated whenever Namenode is being moved.

2016-04-28 Thread Matt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46800/#review131000
---


Fix it, then Ship it!





ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
(line 805)


Missing expect statement for hdfs-client?



ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
(line 827)


Missing expect statement?


- Matt


On April 28, 2016, 2:57 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46800/
> ---
> 
> (Updated April 28, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, Oleksandr 
> Diachenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-16172
> https://issues.apache.org/jira/browse/AMBARI-16172
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ Configuration should be updated whenever Namenode is being moved using 
> the move namenode wizard.
> Parameters which should be updated
> Case 1: HDFS HA
> hdfs-client parameters under HAWQ service
> dfs.namenode.rpc-address..
> dfs.namenode.http-address..
> Case 2: Non HA HDFS
> hawq-site parmeters under HAWQ service
> hawq_dfs_url
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 840bda3 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 1e137ee 
> 
> Diff: https://reviews.apache.org/r/46800/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
>   10505 tests complete (13 seconds)
>   121 tests pending
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 29.607 s
> [INFO] Finished at: 2016-04-28T14:53:42-07:00
> [INFO] Final Memory: 11M/213M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>