Re: Review Request 46851: Express Ugrade stuck on getting status on 1600 node cluster

2016-04-29 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46851/#review131241
---


Ship it!




Ship It!

- Jonathan Hurley


On April 29, 2016, 10:04 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46851/
> ---
> 
> (Updated April 29, 2016, 10:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Bugs: AMBARI-16185
> https://issues.apache.org/jira/browse/AMBARI-16185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calls to the StageResourceProvider are unnecessarily loading all stages and 
> tasks for Blueprint creation request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
>  d3cb96c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  b5d8d5e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
>  2c187a9 
> 
> Diff: https://reviews.apache.org/r/46851/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:13:26.667s
> [INFO] Finished at: Fri Apr 29 20:22:33 EDT 2016
> [INFO] Final Memory: 35M/548M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46851: Express Ugrade stuck on getting status on 1600 node cluster

2016-04-29 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46851/
---

(Updated April 29, 2016, 10:04 p.m.)


Review request for Ambari, Jonathan Hurley and Sid Wagle.


Bugs: AMBARI-16185
https://issues.apache.org/jira/browse/AMBARI-16185


Repository: ambari


Description
---

Calls to the StageResourceProvider are unnecessarily loading all stages and 
tasks for Blueprint creation request.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
 d3cb96c 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 b5d8d5e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
 2c187a9 

Diff: https://reviews.apache.org/r/46851/diff/


Testing (updated)
---

Manual.  Automated:

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:13:26.667s
[INFO] Finished at: Fri Apr 29 20:22:33 EDT 2016
[INFO] Final Memory: 35M/548M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 46851: Express Ugrade stuck on getting status on 1600 node cluster

2016-04-29 Thread Nate Cole 


> On April 29, 2016, 8:17 p.m., Sid Wagle wrote:
> > We did add a feature recently to allow blueprint based deploy with 0 hosts 
> > added to the cluster and thereby it might be possible to have no requests 
> > created. Not sure if it is relevant to this change though.

I tested that scenario with correct results.  Thanks!


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46851/#review131229
---


On April 29, 2016, 7:08 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46851/
> ---
> 
> (Updated April 29, 2016, 7:08 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Bugs: AMBARI-16185
> https://issues.apache.org/jira/browse/AMBARI-16185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calls to the StageResourceProvider are unnecessarily loading all stages and 
> tasks for Blueprint creation request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
>  d3cb96c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  b5d8d5e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
>  2c187a9 
> 
> Diff: https://reviews.apache.org/r/46851/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46851: Express Ugrade stuck on getting status on 1600 node cluster

2016-04-29 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46851/#review131229
---


Ship it!




We did add a feature recently to allow blueprint based deploy with 0 hosts 
added to the cluster and thereby it might be possible to have no requests 
created. Not sure if it is relevant to this change though.

- Sid Wagle


On April 29, 2016, 11:08 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46851/
> ---
> 
> (Updated April 29, 2016, 11:08 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Bugs: AMBARI-16185
> https://issues.apache.org/jira/browse/AMBARI-16185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calls to the StageResourceProvider are unnecessarily loading all stages and 
> tasks for Blueprint creation request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
>  d3cb96c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  b5d8d5e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
>  2c187a9 
> 
> Diff: https://reviews.apache.org/r/46851/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46851: Express Ugrade stuck on getting status on 1600 node cluster

2016-04-29 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46851/
---

(Updated April 29, 2016, 7:08 p.m.)


Review request for Ambari, Jonathan Hurley and Sid Wagle.


Changes
---

@Jonathan got me thinking about a use-case whereby you could ask for the 
logical request directly.  My previous patch wasn't doing that correctly even 
though it achieved the goal of not calling the TopologyManager.getStages() 
every call.


Bugs: AMBARI-16185
https://issues.apache.org/jira/browse/AMBARI-16185


Repository: ambari


Description
---

Calls to the StageResourceProvider are unnecessarily loading all stages and 
tasks for Blueprint creation request.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
 d3cb96c 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 b5d8d5e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
 2c187a9 

Diff: https://reviews.apache.org/r/46851/diff/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 46851: Express Ugrade stuck on getting status on 1600 node cluster

2016-04-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46851/#review131176
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 29, 2016, 7:31 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46851/
> ---
> 
> (Updated April 29, 2016, 7:31 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Bugs: AMBARI-16185
> https://issues.apache.org/jira/browse/AMBARI-16185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calls to the StageResourceProvider are unnecessarily loading all stages and 
> tasks for Blueprint creation request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
>  d3cb96c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  b5d8d5e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
>  2c187a9 
> 
> Diff: https://reviews.apache.org/r/46851/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46851: Express Ugrade stuck on getting status on 1600 node cluster

2016-04-29 Thread Nate Cole 


> On April 29, 2016, 4:05 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java,
> >  lines 223-237
> > 
> >
> > Something to check is whether passing in a real request ID for a 
> > topology request is going to cause problems
> > 
> > For example, during blueprint deployment, will this prevent seeing the 
> > ops in the web client?

Thanks for reviewing.  Ops window show up fine during deployment, and passing a 
request id for a topology request is pulling all stages.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46851/#review131173
---


On April 29, 2016, 3:31 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46851/
> ---
> 
> (Updated April 29, 2016, 3:31 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Bugs: AMBARI-16185
> https://issues.apache.org/jira/browse/AMBARI-16185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calls to the StageResourceProvider are unnecessarily loading all stages and 
> tasks for Blueprint creation request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
>  d3cb96c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  b5d8d5e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
>  2c187a9 
> 
> Diff: https://reviews.apache.org/r/46851/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46851: Express Ugrade stuck on getting status on 1600 node cluster

2016-04-29 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46851/#review131173
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
 (lines 222 - 236)


Something to check is whether passing in a real request ID for a topology 
request is going to cause problems

For example, during blueprint deployment, will this prevent seeing the ops 
in the web client?


- Jonathan Hurley


On April 29, 2016, 3:31 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46851/
> ---
> 
> (Updated April 29, 2016, 3:31 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Bugs: AMBARI-16185
> https://issues.apache.org/jira/browse/AMBARI-16185
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calls to the StageResourceProvider are unnecessarily loading all stages and 
> tasks for Blueprint creation request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java
>  d3cb96c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  b5d8d5e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
>  2c187a9 
> 
> Diff: https://reviews.apache.org/r/46851/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>