Re: Review Request 46889: Improve output of command execution retry logic on agents
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46889/#review131305 --- Ship it! Ship It! - Sandor Magyari On May 2, 2016, 12:05 p.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46889/ > --- > > (Updated May 2, 2016, 12:05 p.m.) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit > Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16199 > https://issues.apache.org/jira/browse/AMBARI-16199 > > > Repository: ambari > > > Description > --- > > When command execution is retried on agent, the output of the command can be > misleading if the first try failed, but the second was successful. > In that case error message remains in the output to indicate that there was a > recovered problem. > > Additional information was added here to indicate that a retry happened and a > summary line that states whether eventually the command was successful or not. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py c5340a0 > ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bca506e > > Diff: https://reviews.apache.org/r/46889/diff/ > > > Testing > --- > > I did manual testing to see the output messages on the UI. > > > Thanks, > > Daniel Gergely > >
Re: Review Request 46889: Improve output of command execution retry logic on agents
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46889/#review131297 --- Ship it! Ship It! - Laszlo Puskas On May 2, 2016, 12:05 p.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46889/ > --- > > (Updated May 2, 2016, 12:05 p.m.) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit > Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16199 > https://issues.apache.org/jira/browse/AMBARI-16199 > > > Repository: ambari > > > Description > --- > > When command execution is retried on agent, the output of the command can be > misleading if the first try failed, but the second was successful. > In that case error message remains in the output to indicate that there was a > recovered problem. > > Additional information was added here to indicate that a retry happened and a > summary line that states whether eventually the command was successful or not. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py c5340a0 > ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bca506e > > Diff: https://reviews.apache.org/r/46889/diff/ > > > Testing > --- > > I did manual testing to see the output messages on the UI. > > > Thanks, > > Daniel Gergely > >
Re: Review Request 46889: Improve output of command execution retry logic on agents
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46889/#review131296 --- Ship it! Ship It! - Oliver Szabo On May 2, 2016, 12:05 p.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46889/ > --- > > (Updated May 2, 2016, 12:05 p.m.) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit > Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16199 > https://issues.apache.org/jira/browse/AMBARI-16199 > > > Repository: ambari > > > Description > --- > > When command execution is retried on agent, the output of the command can be > misleading if the first try failed, but the second was successful. > In that case error message remains in the output to indicate that there was a > recovered problem. > > Additional information was added here to indicate that a retry happened and a > summary line that states whether eventually the command was successful or not. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py c5340a0 > ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bca506e > > Diff: https://reviews.apache.org/r/46889/diff/ > > > Testing > --- > > I did manual testing to see the output messages on the UI. > > > Thanks, > > Daniel Gergely > >
Re: Review Request 46889: Improve output of command execution retry logic on agents
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46889/#review131294 --- Ship it! Ship It! - Sebastian Toader On May 2, 2016, 2:05 p.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46889/ > --- > > (Updated May 2, 2016, 2:05 p.m.) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit > Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16199 > https://issues.apache.org/jira/browse/AMBARI-16199 > > > Repository: ambari > > > Description > --- > > When command execution is retried on agent, the output of the command can be > misleading if the first try failed, but the second was successful. > In that case error message remains in the output to indicate that there was a > recovered problem. > > Additional information was added here to indicate that a retry happened and a > summary line that states whether eventually the command was successful or not. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py c5340a0 > ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bca506e > > Diff: https://reviews.apache.org/r/46889/diff/ > > > Testing > --- > > I did manual testing to see the output messages on the UI. > > > Thanks, > > Daniel Gergely > >
