Re: Review Request 46984: RBAC: Clean up roles after ambari upgrade

2016-05-04 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46984/#review131727
---


Ship it!




Ship It!

- Sebastian Toader


On May 4, 2016, 6:49 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46984/
> ---
> 
> (Updated May 4, 2016, 6:49 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, 
> Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16224
> https://issues.apache.org/jira/browse/AMBARI-16224
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After AMBARI-16102, we no longer support more than 1 role per user. So we 
> need a clean up when user upgrade to Ambari 2.4. If user has more than 1 
> role, we should keep the most "powerful" role and delete the rest.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  dc8d9b7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  3773253 
> 
> Diff: https://reviews.apache.org/r/46984/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade from Ambari 2.2.1 to 2.4.0.
> 
> # Local test results:
> Unrelated errors in unit tests in trunk
> 
> Running org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.583 sec - 
> in org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> 
> 
> Thanks,
> 
> Robert Levas
> 
>



Re: Review Request 46984: RBAC: Clean up roles after ambari upgrade

2016-05-04 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46984/#review131716
---


Ship it!




Ship It!

- Nate Cole


On May 4, 2016, 12:49 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46984/
> ---
> 
> (Updated May 4, 2016, 12:49 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, 
> Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16224
> https://issues.apache.org/jira/browse/AMBARI-16224
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After AMBARI-16102, we no longer support more than 1 role per user. So we 
> need a clean up when user upgrade to Ambari 2.4. If user has more than 1 
> role, we should keep the most "powerful" role and delete the rest.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  dc8d9b7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  3773253 
> 
> Diff: https://reviews.apache.org/r/46984/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade from Ambari 2.2.1 to 2.4.0.
> 
> # Local test results:
> Unrelated errors in unit tests in trunk
> 
> Running org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.583 sec - 
> in org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> 
> 
> Thanks,
> 
> Robert Levas
> 
>