Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-25 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47018/ --- (Updated May 25, 2016, 7:06 p.m.) Review request for Ambari, Alejandro

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-24 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47018/#review134634 --- ambari-server/src/main/resources/property-schema.xsd (lines 1 -

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-24 Thread Nate Cole
> On May 19, 2016, 10:20 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java, > > line 298 > > > > > > Make a constant or read it from XML (if you define XSD

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-24 Thread Nate Cole
> On May 19, 2016, 10:20 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java, > > line 298 > > > > > > Make a constant or read it from XML (if you define XSD

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-24 Thread Dmitro Lisnichenko
> On May 19, 2016, 5:20 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java, > > line 298 > > > > > > Make a constant or read it from XML (if you define XSD

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-24 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47018/ --- (Updated May 24, 2016, 7:11 p.m.) Review request for Ambari, Alejandro

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-23 Thread Nate Cole
> On May 19, 2016, 10:20 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/property-schema.xsd, lines 68-70 > > > > > > All 3 required? > > Dmitro Lisnichenko wrote: > Yes, these are mandatory

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-23 Thread Dmitro Lisnichenko
> On May 19, 2016, 5:20 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/property-schema.xsd, lines 41-42 > > > > > > Requiring both? Both should be optional I would think so that we can > > add

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47018/#review133941 ---

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

2016-05-18 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47018/ --- (Updated May 18, 2016, 8:11 p.m.) Review request for Ambari, Alejandro