Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-11 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/#review132620 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 10, 2016, 5:15

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/#review132464 --- Fix it, then Ship it!

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/ --- (Updated May 10, 2016, 4:02 p.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Gaurav Nagar
> On May 10, 2016, 3:44 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 791-797 > > > > > > I thought in the entities you had this as a Many-To-Many relationship

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/#review132451 ---

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/ --- (Updated May 10, 2016, 11:19 a.m.) Review request for Ambari, DIPAYAN

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-09 Thread Jonathan Hurley
> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 198 > > > > > > I don't think we need the word "ambari" in an

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-09 Thread Jonathan Hurley
> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 198 > > > > > > I don't think we need the word "ambari" in an

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-09 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/ --- (Updated May 9, 2016, 1:44 p.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Gaurav Nagar
> On May 6, 2016, 2:12 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 198 > > > > > > I don't think we need the word "ambari" in an

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Jonathan Hurley
> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 198 > > > > > > I don't think we need the word "ambari" in an

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Gaurav Nagar
> On May 6, 2016, 2:12 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 198 > > > > > > I don't think we need the word "ambari" in an

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/#review132026 --- Fix it, then Ship it!