Re: Review Request 47085: Ambari agent changes to push llap metrics to AMS

2016-05-09 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47085/
---

(Updated May 10, 2016, 12:19 a.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-16296
https://issues.apache.org/jira/browse/AMBARI-16296


Repository: ambari


Description
---

This patch makes start of HiveServer2 Interactive create 
/usr/hdp/current/hive-server2-hive2/conf/conf.server/hadoop-metrics2.properties 
(symlinked from /etc/hive2/conf/conf.server/) with following example content:

*.period=10
*.sink.timeline.plugin.urls=file:///usr/lib/ambari-metrics-hadoop-sink/ambari-metrics-hadoop-sink.jar
*.sink.timeline.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
*.sink.timeline.period=10
*.sink.timeline.sendInterval=6

# HTTPS properties
*.sink.timeline.truststore.path = /etc/security/clientKeys/all.jks
*.sink.timeline.truststore.type = jks
*.sink.timeline.truststore.password = bigdata

llapdaemon.sink.timeline.collector=http://metrics.collector.host.openstacklocal:6188

llapdaemon.sink.timeline_scheduler.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
llapdaemon.sink.timeline_scheduler.context=scheduler
llapdaemon.sink.timeline_scheduler.collector=http://metrics.collector.host.openstacklocal:6188


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 e8532da 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 6a0d777 

Diff: https://reviews.apache.org/r/47085/diff/


Testing
---

Verified that ambari-agent unit tests passes with the patch


Thanks,

Jaimin Jetly



Re: Review Request 47085: Ambari agent changes to push llap metrics to AMS

2016-05-09 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47085/
---

(Updated May 10, 2016, 12:17 a.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.


Changes
---

Attaching 2nd revision of the patch that includes the new requirement of 
splitting the metrics properties file into two:
one for llapdaemon and another for llaptaskscheduler


Bugs: AMBARI-16296
https://issues.apache.org/jira/browse/AMBARI-16296


Repository: ambari


Description
---

This patch makes start of HiveServer2 Interactive create 
/usr/hdp/current/hive-server2-hive2/conf/conf.server/hadoop-metrics2.properties 
(symlinked from /etc/hive2/conf/conf.server/) with following example content:

*.period=10
*.sink.timeline.plugin.urls=file:///usr/lib/ambari-metrics-hadoop-sink/ambari-metrics-hadoop-sink.jar
*.sink.timeline.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
*.sink.timeline.period=10
*.sink.timeline.sendInterval=6

# HTTPS properties
*.sink.timeline.truststore.path = /etc/security/clientKeys/all.jks
*.sink.timeline.truststore.type = jks
*.sink.timeline.truststore.password = bigdata

llapdaemon.sink.timeline.collector=http://metrics.collector.host.openstacklocal:6188

llapdaemon.sink.timeline_scheduler.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
llapdaemon.sink.timeline_scheduler.context=scheduler
llapdaemon.sink.timeline_scheduler.collector=http://metrics.collector.host.openstacklocal:6188


Diffs (updated)
-

  ambari-web/app/mixins/common/configs/configs_saver.js 1f81ef1 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
080fff1 

Diff: https://reviews.apache.org/r/47085/diff/


Testing
---

Verified that ambari-agent unit tests passes with the patch


Thanks,

Jaimin Jetly



Re: Review Request 47085: Ambari agent changes to push llap metrics to AMS

2016-05-06 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47085/#review132120
---


Ship it!




Ship It!

- Sumit Mohanty


On May 7, 2016, 1:34 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47085/
> ---
> 
> (Updated May 7, 2016, 1:34 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16296
> https://issues.apache.org/jira/browse/AMBARI-16296
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch makes start of HiveServer2 Interactive create 
> /usr/hdp/current/hive-server2-hive2/conf/conf.server/hadoop-metrics2.properties
>  (symlinked from /etc/hive2/conf/conf.server/) with following example content:
> 
> *.period=10
> *.sink.timeline.plugin.urls=file:///usr/lib/ambari-metrics-hadoop-sink/ambari-metrics-hadoop-sink.jar
> *.sink.timeline.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
> *.sink.timeline.period=10
> *.sink.timeline.sendInterval=6
> 
> # HTTPS properties
> *.sink.timeline.truststore.path = /etc/security/clientKeys/all.jks
> *.sink.timeline.truststore.type = jks
> *.sink.timeline.truststore.password = bigdata
> 
> llapdaemon.sink.timeline.collector=http://metrics.collector.host.openstacklocal:6188
> 
> llapdaemon.sink.timeline_scheduler.class=org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink
> llapdaemon.sink.timeline_scheduler.context=scheduler
> llapdaemon.sink.timeline_scheduler.collector=http://metrics.collector.host.openstacklocal:6188
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  e8532da 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2.properties.j2
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 6a0d777 
> 
> Diff: https://reviews.apache.org/r/47085/diff/
> 
> 
> Testing
> ---
> 
> Verified that ambari-agent unit tests passes with the patch
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>