Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/ --- (Updated May 10, 2016, 7:58 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132523 --- Ship it! Ship It! - Ajit Kumar On May 10, 2016, 7:56 p.m.,

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/ --- (Updated May 10, 2016, 7:56 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/ --- (Updated May 10, 2016, 7:39 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
> On May 10, 2016, 7:01 p.m., Ajit Kumar wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java, > > line 561 > >

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Ajit Kumar
> On May 10, 2016, 7:01 p.m., Ajit Kumar wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java, > > line 161 > >

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
> On May 10, 2016, 7:01 p.m., Ajit Kumar wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/ConditionBuilder.java, > > line 29 > >

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132516 ---

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132515 ---

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132514 --- Ship it! Ship It! - Sid Wagle On May 10, 2016, 6:41 p.m.,

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/ --- (Updated May 10, 2016, 6:41 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/ --- (Updated May 10, 2016, 5:34 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Sid Wagle
> On May 10, 2016, 12:27 a.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java, > > line 308 > >

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-10 Thread Aravindan Vijayan
> On May 10, 2016, 12:27 a.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java, > > line 308 > >

Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS

2016-05-09 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132356 --- Fix it, then Ship it!