Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Robert Nettleton
> On May 12, 2016, 1:35 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java, > > line 46 > > > > > > This change is problematic, since

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/#review133099 --- Ship it! Ship It! - Robert Nettleton On May 13, 2016, 6:48

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Dharmesh Makwana
> On May 12, 2016, 1:35 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java, > > line 56 > >

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Dharmesh Makwana
> On May 12, 2016, 3:37 p.m., Sumit Mohanty wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java, > > line 147 > > > > > > Any reason this is being removed?

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/ --- (Updated May 13, 2016, 6:48 a.m.) Review request for Ambari, Alejandro

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/#review132928 ---

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/#review132892 --- Thanks for contributing this patch. I believe that some more

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47296/ --- (Updated May 12, 2016, 11:31 a.m.) Review request for Ambari, Alejandro