Re: Review Request 47452: Do not use implicit routing by default in solr-client

[Don Bosco Durai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47452/#review134480
---


Ship it!




Ship It!

- Don Bosco Durai


On May 17, 2016, 1:29 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47452/
> ---
> 
> (Updated May 17, 2016, 1:29 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16701
> https://issues.apache.org/jira/browse/AMBARI-16701
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> By default ambari should not use implicit routing for creating collections
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  d661288 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  21e7fee 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
>  c888269 
> 
> Diff: https://reviews.apache.org/r/47452/diff/
> 
> 
> Testing
> ---
> 
> ambari logsearch solr-client tests:
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47452: Do not use implicit routing by default in solr-client

[Oliver Szabo]

> On May 23, 2016, 11:24 p.m., Don Bosco Durai wrote:
> > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java,
> >  line 54
> > 
> >
> > During Create collection, shards is a valid value. Only after the 
> > collection is created, you can't add shards to SolrCloud using compositeId

sorry, the comment is below for this one


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47452/#review134474
---


On May 17, 2016, 1:29 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47452/
> ---
> 
> (Updated May 17, 2016, 1:29 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16701
> https://issues.apache.org/jira/browse/AMBARI-16701
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> By default ambari should not use implicit routing for creating collections
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  d661288 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  21e7fee 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
>  c888269 
> 
> Diff: https://reviews.apache.org/r/47452/diff/
> 
> 
> Testing
> ---
> 
> ambari logsearch solr-client tests:
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47452: Do not use implicit routing by default in solr-client

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47452/#review134478
---




ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
 (line 53)


It's like that you described. but you cam switch that off, by default its 
used.


- Oliver Szabo


On May 17, 2016, 1:29 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47452/
> ---
> 
> (Updated May 17, 2016, 1:29 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16701
> https://issues.apache.org/jira/browse/AMBARI-16701
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> By default ambari should not use implicit routing for creating collections
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  d661288 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  21e7fee 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
>  c888269 
> 
> Diff: https://reviews.apache.org/r/47452/diff/
> 
> 
> Testing
> ---
> 
> ambari logsearch solr-client tests:
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47452: Do not use implicit routing by default in solr-client

[Don Bosco Durai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47452/#review134474
---


Fix it, then Ship it!




Ship it after reviewing feedback. Thanks


ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
 (line 53)


During Create collection, shards is a valid value. Only after the 
collection is created, you can't add shards to SolrCloud using compositeId


- Don Bosco Durai


On May 17, 2016, 1:29 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47452/
> ---
> 
> (Updated May 17, 2016, 1:29 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16701
> https://issues.apache.org/jira/browse/AMBARI-16701
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> By default ambari should not use implicit routing for creating collections
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  d661288 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  21e7fee 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
>  c888269 
> 
> Diff: https://reviews.apache.org/r/47452/diff/
> 
> 
> Testing
> ---
> 
> ambari logsearch solr-client tests:
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47452: Do not use implicit routing by default in solr-client

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47452/#review133578
---


Ship it!




Ship It!

- Robert Nettleton


On May 17, 2016, 1:29 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47452/
> ---
> 
> (Updated May 17, 2016, 1:29 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16701
> https://issues.apache.org/jira/browse/AMBARI-16701
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> By default ambari should not use implicit routing for creating collections
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  d661288 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  21e7fee 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
>  c888269 
> 
> Diff: https://reviews.apache.org/r/47452/diff/
> 
> 
> Testing
> ---
> 
> ambari logsearch solr-client tests:
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47452: Do not use implicit routing by default in solr-client

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47452/
---

(Updated May 17, 2016, 1:29 p.m.)


Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, and 
Sumit Mohanty.


Changes
---

fixed compile error


Bugs: AMBARI-16701
https://issues.apache.org/jira/browse/AMBARI-16701


Repository: ambari


Description
---

By default ambari should not use implicit routing for creating collections


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 d661288 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 21e7fee 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
 c888269 

Diff: https://reviews.apache.org/r/47452/diff/


Testing
---

ambari logsearch solr-client tests:
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Oliver Szabo