Re: Review Request 47477: clean up import * for HDFS service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47477/#review134042 --- Ship it! Ship It! - Jayush Luniya On May 18, 2016, 4:49 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47477/ > --- > > (Updated May 18, 2016, 4:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16362 > https://issues.apache.org/jira/browse/AMBARI-16362 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for HDFS service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > 79c32e4 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > 1264284 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > d9b76b8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py > a22fb99 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py > 500ed15 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > 9c5a124 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > b37f413 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py > da00985 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py > 737ae04 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py > 30eee07 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > ceee738 > > Diff: https://reviews.apache.org/r/47477/diff/ > > > Testing > --- > > Pass mvn clean test -DskipSurefireTests > HDFS fresh installation and service check > Hadoop QA: > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 47477: clean up import * for HDFS service scripts in common-services
> On May 18, 2016, 5:24 p.m., Alejandro Fernandez wrote: > > Ship It! Can someone please ship this patch for me? I do not have committer privileges - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47477/#review133767 --- On May 18, 2016, 4:49 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47477/ > --- > > (Updated May 18, 2016, 4:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16362 > https://issues.apache.org/jira/browse/AMBARI-16362 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for HDFS service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > 79c32e4 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > 1264284 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > d9b76b8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py > a22fb99 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py > 500ed15 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > 9c5a124 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > b37f413 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py > da00985 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py > 737ae04 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py > 30eee07 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > ceee738 > > Diff: https://reviews.apache.org/r/47477/diff/ > > > Testing > --- > > Pass mvn clean test -DskipSurefireTests > HDFS fresh installation and service check > Hadoop QA: > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 47477: clean up import * for HDFS service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47477/#review133827 --- Ship it! Ship It! - Matt On May 18, 2016, 9:49 a.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47477/ > --- > > (Updated May 18, 2016, 9:49 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16362 > https://issues.apache.org/jira/browse/AMBARI-16362 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for HDFS service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > 79c32e4 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > 1264284 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > d9b76b8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py > a22fb99 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py > 500ed15 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > 9c5a124 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > b37f413 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py > da00985 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py > 737ae04 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py > 30eee07 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > ceee738 > > Diff: https://reviews.apache.org/r/47477/diff/ > > > Testing > --- > > Pass mvn clean test -DskipSurefireTests > HDFS fresh installation and service check > Hadoop QA: > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 47477: clean up import * for HDFS service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47477/#review133767 --- Ship it! Ship It! - Alejandro Fernandez On May 18, 2016, 4:49 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47477/ > --- > > (Updated May 18, 2016, 4:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16362 > https://issues.apache.org/jira/browse/AMBARI-16362 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for HDFS service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > 79c32e4 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > 1264284 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > d9b76b8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py > a22fb99 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py > 500ed15 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > 9c5a124 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > b37f413 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py > da00985 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py > 737ae04 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py > 30eee07 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py > ceee738 > > Diff: https://reviews.apache.org/r/47477/diff/ > > > Testing > --- > > Pass mvn clean test -DskipSurefireTests > HDFS fresh installation and service check > Hadoop QA: > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 47477: clean up import * for HDFS service scripts in common-services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47477/ --- (Updated May 18, 2016, 4:49 p.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. Bugs: AMBARI-16362 https://issues.apache.org/jira/browse/AMBARI-16362 Repository: ambari Description --- Python code at at common-services level used generic imports form resource_management (from resource_management import *) Ideally, for easier code tracking and performance, these import should be more specific, such as: from resource_management.libraries.script.script import Script from resource_management.core.resources.system import Directory This patch cleans up import * from resource_management for HDFS service scripts in common-services Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 79c32e4 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py 1264284 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py d9b76b8 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py a22fb99 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py 500ed15 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 9c5a124 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py b37f413 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py da00985 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py 737ae04 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 30eee07 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py ceee738 Diff: https://reviews.apache.org/r/47477/diff/ Testing --- Pass mvn clean test -DskipSurefireTests HDFS fresh installation and service check Hadoop QA: -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console This message is automatically generated. Thanks, Juanjo Marron