Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Anita Jebaraj]

> On June 17, 2016, 2:33 p.m., Di Li wrote:
> > Hello Anita,
> > 
> > could you please close this one if it has been submitted?

Sure Di


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review138222
---


On May 18, 2016, 7:05 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> fda2ab4 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review138222
---



Hello Anita,

could you please close this one if it has been submitted?

- Di Li


On May 18, 2016, 7:05 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> fda2ab4 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Alexandr Antonenko]

> On May 18, 2016, 9:15 p.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Anita Jebaraj wrote:
> Thank you Alex, can you please help me to push the changes

no problem.

yes ofc, I will commit


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review133814
---


On May 18, 2016, 7:05 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> fda2ab4 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Anita Jebaraj]

> On May 18, 2016, 9:15 p.m., Alexandr Antonenko wrote:
> > Ship It!

Thank you Alex, can you please help me to push the changes


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review133814
---


On May 18, 2016, 7:05 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> fda2ab4 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review133814
---


Ship it!




Ship It!

- Alexandr Antonenko


On May 18, 2016, 7:05 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> fda2ab4 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/
---

(Updated May 18, 2016, 7:05 p.m.)


Review request for Ambari, Alexandr Antonenko and Di Li.


Changes
---

Made the changes suggested by Alex, changed to setEach


Bugs: AMBARI-15951
https://issues.apache.org/jira/browse/AMBARI-15951


Repository: ambari


Description
---

1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
2. In the wizard, select Existing Active Directory for e.g.
3. Check all the pre-requisites.
4. Click on Next to get to the Configure Kerberos page.
5. Click on Back.
6. The type of KDC radio button gets reset to Existing MIT KDC.
7. Same thing happens if you Navigate to Install and Test Kerberos Client page 
and navigate back to the second or first page of the wizard.

Expected results:
Like other wizards such as Add Service Wizard, the wizard should remember 
selections/data when navigating back in the wizard.


Diffs (updated)
-

  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
  ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
  ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
fda2ab4 

Diff: https://reviews.apache.org/r/47514/diff/


Testing
---

Ran mvn test
27719 tests complete (32 seconds)
154 tests pending


Thanks,

Anita Jebaraj

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review133754
---




ambari-web/app/controllers/main/admin/kerberos/step1_controller.js (line 130)


Please use setEach

options.forEach(function (option) {
  option.preConditions.setEach('checked', false)
})


- Alexandr Antonenko


On May 18, 2016, 5:21 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 5:21 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> 280f923 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>