Re: Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47539/#review133912
---




ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 (line 86)


class="col-sm-3;padding-left-30" --> class names should be delimited by 
simple space, using sign ";" is wrong. I commit with that change.


- Alexandr Antonenko


On May 18, 2016, 3:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47539/
> ---
> 
> (Updated May 18, 2016, 3:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and DIPAYAN BHOWMICK.
> 
> 
> Bugs: AMBARI-16404
> https://issues.apache.org/jira/browse/AMBARI-16404
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the latest trunk code, the HUETOAMBARI_MIGRATION view name  spills over 
> to the next line.
> 
> Fix involves changing the css class for the view name column to col-sm-4 and 
> changing css class for first column of view instance row to 
> col-sm-3;padding-left-30
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  906eef5 
> 
> Diff: https://reviews.apache.org/r/47539/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

[Alexandr Antonenko]

> On May 18, 2016, 4:01 p.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Sangeeta Ravindran wrote:
> Thanks, can you please help push the fix.

yes ofc, will do it


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47539/#review133757
---


On May 18, 2016, 3:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47539/
> ---
> 
> (Updated May 18, 2016, 3:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and DIPAYAN BHOWMICK.
> 
> 
> Bugs: AMBARI-16404
> https://issues.apache.org/jira/browse/AMBARI-16404
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the latest trunk code, the HUETOAMBARI_MIGRATION view name  spills over 
> to the next line.
> 
> Fix involves changing the css class for the view name column to col-sm-4 and 
> changing css class for first column of view instance row to 
> col-sm-3;padding-left-30
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  906eef5 
> 
> Diff: https://reviews.apache.org/r/47539/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

[Sangeeta Ravindran]

> On May 18, 2016, 4:01 p.m., Alexandr Antonenko wrote:
> > Ship It!

Thanks, can you please help push the fix.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47539/#review133757
---


On May 18, 2016, 3:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47539/
> ---
> 
> (Updated May 18, 2016, 3:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and DIPAYAN BHOWMICK.
> 
> 
> Bugs: AMBARI-16404
> https://issues.apache.org/jira/browse/AMBARI-16404
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the latest trunk code, the HUETOAMBARI_MIGRATION view name  spills over 
> to the next line.
> 
> Fix involves changing the css class for the view name column to col-sm-4 and 
> changing css class for first column of view instance row to 
> col-sm-3;padding-left-30
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  906eef5 
> 
> Diff: https://reviews.apache.org/r/47539/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47539/#review133757
---


Ship it!




Ship It!

- Alexandr Antonenko


On May 18, 2016, 3:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47539/
> ---
> 
> (Updated May 18, 2016, 3:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and DIPAYAN BHOWMICK.
> 
> 
> Bugs: AMBARI-16404
> https://issues.apache.org/jira/browse/AMBARI-16404
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the latest trunk code, the HUETOAMBARI_MIGRATION view name  spills over 
> to the next line.
> 
> Fix involves changing the css class for the view name column to col-sm-4 and 
> changing css class for first column of view instance row to 
> col-sm-3;padding-left-30
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  906eef5 
> 
> Diff: https://reviews.apache.org/r/47539/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>