Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-24 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134606
---


Ship it!




Ship It!

- Swapan Shridhar


On May 23, 2016, 8:20 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 23, 2016, 8:20 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-24 Thread Daniel Gergely 


> On máj. 24, 2016, 4:03 de, Swapan Shridhar wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, 
> > line 221
> > 
> >
> > Can you explain how moving this line up helps ? Thx.

I moved it up to make sure that this setting has a correct value all the time, 
even if calculations are skipped. Skip points have been added, so tracking them 
and add this value everywhere would not be a good solution.
Moving the line up makes sure that the initial value for that property is 
correct, but later in the function it can be overwritten with a calculated 
value (if those parts are not skipped).

If the memory setting is not correct, then hive interactive server won't start.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134511
---


On máj. 23, 2016, 8:20 de, Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated máj. 23, 2016, 8:20 de)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-23 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134511
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
221)


Can you explain how moving this line up helps ? Thx.


- Swapan Shridhar


On May 23, 2016, 8:20 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 23, 2016, 8:20 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Sandor Magyari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134151
---


Ship it!




Ship It!

- Sandor Magyari


On May 20, 2016, 8:01 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 20, 2016, 8:01 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134149
---


Ship it!




Ship It!

- Laszlo Puskas


On May 20, 2016, 8:01 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 20, 2016, 8:01 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134148
---


Ship it!




Ship It!

- Oliver Szabo


On May 20, 2016, 8:01 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 20, 2016, 8:01 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-20 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134122
---


Ship it!




Ship It!

- Sebastian Toader


On May 20, 2016, 10:01 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 20, 2016, 10:01 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-19 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review133991
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 (line 433)


I think its better to introduce a variable here through which the default 
value of this property can be linked to the default value of 
```yarn.scheduler.minimum-allocation-mb``` so it doesn't has to be changed in 
two places if the default value changes.

As an example look at ```{{storm_thrift_transport}}``` in storm-site.xml 
and storm's params_linux.py


- Sebastian Toader


On May 19, 2016, 6:55 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 19, 2016, 6:55 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>