Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47643/#review134530
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 23, 2016, 5:25 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47643/
> ---
> 
> (Updated May 23, 2016, 5:25 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-16792
> https://issues.apache.org/jira/browse/AMBARI-16792
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Edit and validate queue name
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  02062a6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  69be18c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  89d0e89 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  a60d39d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  d57b2ba 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  c5c910a 
> 
> Diff: https://reviews.apache.org/r/47643/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47643/#review134326
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On May 23, 2016, 5:25 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47643/
> ---
> 
> (Updated May 23, 2016, 5:25 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-16792
> https://issues.apache.org/jira/browse/AMBARI-16792
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Edit and validate queue name
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  02062a6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  69be18c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  89d0e89 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  a60d39d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  d57b2ba 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  c5c910a 
> 
> Diff: https://reviews.apache.org/r/47643/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name

[Akhil PB]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47643/
---

(Updated May 23, 2016, 5:25 a.m.)


Review request for Ambari and Sreenath Somarajapuram.


Changes
---

Patch updated with feedback


Bugs: AMBARI-16792
https://issues.apache.org/jira/browse/AMBARI-16792


Repository: ambari


Description
---

Capacity Scheduler View - Edit and validate queue name


Diffs (updated)
-

  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 02062a6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 69be18c 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 89d0e89 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 a60d39d 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 d57b2ba 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 c5c910a 

Diff: https://reviews.apache.org/r/47643/diff/


Testing
---

Manual Unit Testing


Thanks,

Akhil PB

Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47643/#review134190
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 (line 50)


This need to be corrected.


- Sreenath Somarajapuram


On May 20, 2016, 9:57 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47643/
> ---
> 
> (Updated May 20, 2016, 9:57 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-16792
> https://issues.apache.org/jira/browse/AMBARI-16792
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Edit and validate queue name
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  02062a6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  69be18c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  89d0e89 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  a60d39d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  d57b2ba 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  c5c910a 
> 
> Diff: https://reviews.apache.org/r/47643/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>