----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47688/#review134251 -----------------------------------------------------------
Ship it! Ship It! - Sumit Mohanty On May 21, 2016, 2:55 a.m., Nahappan Somasundaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47688/ > ----------------------------------------------------------- > > (Updated May 21, 2016, 2:55 a.m.) > > > Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-16806 > https://issues.apache.org/jira/browse/AMBARI-16806 > > > Repository: ambari > > > Description > ------- > > AMBARI-16806: AMS Collector is not automatically being configured for > auto-start during blueprint deployment > > ** Issue ** > When using blueprint to deploy a cluster, if settings section is not > specified, AMBARI_METRICS::METRICS_COLLECTOR is not flagged for auto start, > even though it's stack definition > /var/lib/ambari-server/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml > has the *<recovery_enabled>true</recovery_enabled>* entry. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > dd2b31b > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > e3b51c0 > > ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java > 2fc74de > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java > 0bb4874 > > Diff: https://reviews.apache.org/r/47688/diff/ > > > Testing > ------- > > ** 1. mvn clean install ** > > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [7.132s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.037s] > [INFO] Ambari Web ........................................ SUCCESS [24.088s] > [INFO] Ambari Views ...................................... SUCCESS [1.079s] > [INFO] Ambari Admin View ................................. SUCCESS [9.173s] > [INFO] ambari-metrics .................................... SUCCESS [0.396s] > [INFO] Ambari Metrics Common ............................. SUCCESS [0.540s] > [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.122s] > [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.613s] > [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [0.657s] > [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.810s] > [INFO] Ambari Metrics Collector .......................... SUCCESS [6.481s] > [INFO] Ambari Metrics Monitor ............................ SUCCESS [1.698s] > [INFO] Ambari Metrics Grafana ............................ SUCCESS [0.820s] > [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:15.107s] > [INFO] Ambari Server ..................................... SUCCESS [2:27.216s] > [INFO] Ambari Functional Tests ........................... SUCCESS [0.982s] > [INFO] Ambari Agent ...................................... SUCCESS [24.414s] > [INFO] Ambari Client ..................................... SUCCESS [0.046s] > [INFO] Ambari Python Client .............................. SUCCESS [0.969s] > [INFO] Ambari Groovy Client .............................. SUCCESS [2.147s] > [INFO] Ambari Shell ...................................... SUCCESS [0.036s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.655s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [0.828s] > [INFO] ambari-logsearch .................................. SUCCESS [0.197s] > [INFO] Ambari Logsearch Appender ......................... SUCCESS [0.223s] > [INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.038s] > [INFO] Ambari Logsearch Portal ........................... SUCCESS [6.675s] > [INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [2.395s] > [INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.085s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 5:19.362s > [INFO] Finished at: Fri May 20 19:54:12 PDT 2016 > [INFO] Final Memory: 292M/1190M > [INFO] > ------------------------------------------------------------------------ > > ** 2. mvn test -DskipPythonTests -Dtest=AmbariContextTest,BlueprintImplTest ** > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.server.topology.AmbariContextTest > Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.795 sec - > in org.apache.ambari.server.topology.AmbariContextTest > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.server.topology.BlueprintImplTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.196 sec - > in org.apache.ambari.server.topology.BlueprintImplTest > > Results : > > Tests run: 14, Failures: 0, Errors: 0, Skipped: 0 > > ** 3. Manual tests ** > Deployed a single node VM with the latest trunk build and overwrote > ambari-server JAR with the one from the local build. Use a blueprint without > the *setting* section that supports auto start. All auto start values should > be picked up from the stack definition. > > Create the blueprint: > curl -u admin:admin -H "X-Requested-By: ambari" -X POST -d > @/tmp/blueprints2.json http://localhost:8080/api/v1/blueprints/bp2 > Deploy the cluster: > curl -u admin:admin -H "X-Requested-By: ambari" -X POST -d @/tmp/hg2.json > http://localhost:8080/api/v1/clusters/c1 > > ambari=> select * from servicecomponentdesiredstate where recovery_enabled=1; > id | component_name | cluster_id | desired_stack_id | desired_version | > desired_state | service_name | recovery_enabled > ----+-------------------+------------+------------------+-----------------+---------------+----------------+----------- > ------- > 1 | METRICS_COLLECTOR | 2 | 8 | UNKNOWN | > STARTED | AMBARI_METRICS | 1 > (1 row) > > > Thanks, > > Nahappan Somasundaram > >
