Re: Review Request 47790: Failed to install packages for HDP 2.4 and 2.5

2016-05-25 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47790/#review134819
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 (line 378)


Assume current stack is 2.3
Does this still allow installing in this order in the same stack?

1. HDP 2.5.2.0
2. HDP 2.5.0.0

I agree that installing 2.4 after any 2.5 has been installed is problematic.


- Alejandro Fernandez


On May 25, 2016, 2:07 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47790/
> ---
> 
> (Updated May 25, 2016, 2:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16854
> https://issues.apache.org/jira/browse/AMBARI-16854
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1. Install 2.3.0.0
> 2. Register and Install 2.5.0.0 (with or without package-version; it gets 
> computed correctly)
> 3. Register 2.4 as the stack version (without package-version)
> 
> Installation of 2.4 will fail because the way agents invoke installation is 
> to install by name.  If the package-version is not known, then the 'newest' 
> is ALWAYS installed.  In this case, that would be 2.5.0.0.  2.4 is never 
> picked up as the correct repository.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  9dc5c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  3c9a91d 
> 
> Diff: https://reviews.apache.org/r/47790/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4357, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 35:22.629s
> [INFO] Finished at: Tue May 24 21:38:01 EDT 2016
> [INFO] Final Memory: 34M/596M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 47790: Failed to install packages for HDP 2.4 and 2.5

2016-05-25 Thread Nate Cole 


> On May 24, 2016, 10:35 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java,
> >  line 886
> > 
> >
> > What exactly is "version1" here .. is it 2.3.0.0-1234 or 
> > HDP-2.3.0.0-1234? My concern is that a version of HDP and a version of XYZ 
> > might exist and cause this to have a false positive on higher versions. Do 
> > we need to compare within the same stack?

Good point - will add that as well.  I suspect this will all need to change too 
once we start supporting varied-versioned components.


> On May 24, 2016, 10:35 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java,
> >  line 888
> > 
> >
> > StringUtils for null safety?

Will fix.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47790/#review134684
---


On May 24, 2016, 10:07 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47790/
> ---
> 
> (Updated May 24, 2016, 10:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16854
> https://issues.apache.org/jira/browse/AMBARI-16854
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1. Install 2.3.0.0
> 2. Register and Install 2.5.0.0 (with or without package-version; it gets 
> computed correctly)
> 3. Register 2.4 as the stack version (without package-version)
> 
> Installation of 2.4 will fail because the way agents invoke installation is 
> to install by name.  If the package-version is not known, then the 'newest' 
> is ALWAYS installed.  In this case, that would be 2.5.0.0.  2.4 is never 
> picked up as the correct repository.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  9dc5c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  3c9a91d 
> 
> Diff: https://reviews.apache.org/r/47790/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4357, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 35:22.629s
> [INFO] Finished at: Tue May 24 21:38:01 EDT 2016
> [INFO] Final Memory: 34M/596M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 47790: Failed to install packages for HDP 2.4 and 2.5

2016-05-24 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47790/#review134684
---


Fix it, then Ship it!




Just the one comment really about the stack names being compared as well.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 (line 886)


What exactly is "version1" here .. is it 2.3.0.0-1234 or HDP-2.3.0.0-1234? 
My concern is that a version of HDP and a version of XYZ might exist and cause 
this to have a false positive on higher versions. Do we need to compare within 
the same stack?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 (line 888)


StringUtils for null safety?


- Jonathan Hurley


On May 24, 2016, 10:07 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47790/
> ---
> 
> (Updated May 24, 2016, 10:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16854
> https://issues.apache.org/jira/browse/AMBARI-16854
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1. Install 2.3.0.0
> 2. Register and Install 2.5.0.0 (with or without package-version; it gets 
> computed correctly)
> 3. Register 2.4 as the stack version (without package-version)
> 
> Installation of 2.4 will fail because the way agents invoke installation is 
> to install by name.  If the package-version is not known, then the 'newest' 
> is ALWAYS installed.  In this case, that would be 2.5.0.0.  2.4 is never 
> picked up as the correct repository.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  9dc5c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  3c9a91d 
> 
> Diff: https://reviews.apache.org/r/47790/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4357, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 35:22.629s
> [INFO] Finished at: Tue May 24 21:38:01 EDT 2016
> [INFO] Final Memory: 34M/596M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 47790: Failed to install packages for HDP 2.4 and 2.5

2016-05-24 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47790/
---

(Updated May 24, 2016, 10:07 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-16854
https://issues.apache.org/jira/browse/AMBARI-16854


Repository: ambari


Description
---

STR:
1. Install 2.3.0.0
2. Register and Install 2.5.0.0 (with or without package-version; it gets 
computed correctly)
3. Register 2.4 as the stack version (without package-version)

Installation of 2.4 will fail because the way agents invoke installation is to 
install by name.  If the package-version is not known, then the 'newest' is 
ALWAYS installed.  In this case, that would be 2.5.0.0.  2.4 is never picked up 
as the correct repository.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 9dc5c4d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
 3c9a91d 

Diff: https://reviews.apache.org/r/47790/diff/


Testing (updated)
---

Manual.  Automated:

Tests run: 4357, Failures: 0, Errors: 0, Skipped: 34

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 35:22.629s
[INFO] Finished at: Tue May 24 21:38:01 EDT 2016
[INFO] Final Memory: 34M/596M
[INFO] 


Thanks,

Nate Cole