Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review135055
---


Ship it!




Ship It!

- Jonathan Hurley


On May 26, 2016, 4:03 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47871/
> ---
> 
> (Updated May 26, 2016, 4:03 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.5 is introducing breaking changes for Storm, so must apply config 
> changes and delete all local storm data plus data on Zookeeper.
> EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following
> 
> Apply config changes
> Delete Storm data on ZK only once
> Delete Storm local data on all Storm hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  dd033b8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 525a356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 9ee3e88 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  625b851 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 58aa95f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> cdb8634 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 5211276 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d90d76d 
> 
> Diff: https://reviews.apache.org/r/47871/diff/
> 
> 
> Testing
> ---
> 
> Verified EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/
---

(Updated May 26, 2016, 8:03 p.m.)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
Hurley, Nate Cole, and Swapan Shridhar.


Bugs: AMBARI-16648
https://issues.apache.org/jira/browse/AMBARI-16648


Repository: ambari


Description
---

HDP 2.5 is introducing breaking changes for Storm, so must apply config changes 
and delete all local storm data plus data on Zookeeper.
EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following

Apply config changes
Delete Storm data on ZK only once
Delete Storm local data on all Storm hosts


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 dd033b8 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
525a356 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
9ee3e88 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 625b851 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
58aa95f 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
cdb8634 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
5211276 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
d90d76d 

Diff: https://reviews.apache.org/r/47871/diff/


Testing (updated)
---

Verified EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm


Thanks,

Alejandro Fernandez

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Alejandro Fernandez 


> On May 26, 2016, 4:42 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml, 
> > lines 860-863
> > 
> >
> > The Jira says:
> > ```
> > Delete Storm data on ZK only once
> > Delete Storm local data on all Storm hosts
> > ```
> > 
> > Nimbus's cardinality is 1, right? If so, then that's fine - I just want 
> > to make sure we can't possible be deleting ZK data more than once.
> 
> Alejandro Fernandez wrote:
> Yes, cardinality is 1. The command to delete storm data from ZK is 
> idempotent (rmr still works if the znode does not exist).

Actually, there can be multiple Nimbus hosts.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review135001
---


On May 26, 2016, 1:54 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47871/
> ---
> 
> (Updated May 26, 2016, 1:54 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.5 is introducing breaking changes for Storm, so must apply config 
> changes and delete all local storm data plus data on Zookeeper.
> EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following
> 
> Apply config changes
> Delete Storm data on ZK only once
> Delete Storm local data on all Storm hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  dd033b8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 525a356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 9ee3e88 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  625b851 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 58aa95f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> cdb8634 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 5211276 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d90d76d 
> 
> Diff: https://reviews.apache.org/r/47871/diff/
> 
> 
> Testing
> ---
> 
> Testing on EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review135001
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (lines 
860 - 863)


The Jira says:
```
Delete Storm data on ZK only once
Delete Storm local data on all Storm hosts
```

Nimbus's cardinality is 1, right? If so, then that's fine - I just want to 
make sure we can't possible be deleting ZK data more than once.


- Jonathan Hurley


On May 25, 2016, 9:54 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47871/
> ---
> 
> (Updated May 25, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.5 is introducing breaking changes for Storm, so must apply config 
> changes and delete all local storm data plus data on Zookeeper.
> EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following
> 
> Apply config changes
> Delete Storm data on ZK only once
> Delete Storm local data on all Storm hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  dd033b8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 525a356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 9ee3e88 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  625b851 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 58aa95f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> cdb8634 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 5211276 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d90d76d 
> 
> Diff: https://reviews.apache.org/r/47871/diff/
> 
> 
> Testing
> ---
> 
> Testing on EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 47871: Support Storm 1.0 in EU/RU to HDP 2.5

2016-05-26 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47871/#review134974
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (lines 
897 - 899)


Why does downgrade get this message but not upgrade?


- Nate Cole


On May 25, 2016, 9:54 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47871/
> ---
> 
> (Updated May 25, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16648
> https://issues.apache.org/jira/browse/AMBARI-16648
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.5 is introducing breaking changes for Storm, so must apply config 
> changes and delete all local storm data plus data on Zookeeper.
> EU and RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 must do the following
> 
> Apply config changes
> Delete Storm data on ZK only once
> Delete Storm local data on all Storm hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  dd033b8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 525a356 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 9ee3e88 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  625b851 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 58aa95f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> cdb8634 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 5211276 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d90d76d 
> 
> Diff: https://reviews.apache.org/r/47871/diff/
> 
> 
> Testing
> ---
> 
> Testing on EU/RU from HDP 2.3 -> 2.5 and 2.4 -> 2.5 with Storm
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>