Re: Review Request 47965: clean up import * for RANGER service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47965/#review135751 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 4:41 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47965/ > --- > > (Updated May 27, 2016, 4:41 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16743 > https://issues.apache.org/jira/browse/AMBARI-16743 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for RANGER service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py > 2c7bd3c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > 3dc4914 > > Diff: https://reviews.apache.org/r/47965/diff/ > > > Testing > --- > > Hadoop QA added a comment - 3 hours ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12806494/AMBARI-16743.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7015//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7015//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
Re: Review Request 47965: clean up import * for RANGER service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47965/#review135265 --- Ship it! Ship It! - Alejandro Fernandez On May 27, 2016, 4:41 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47965/ > --- > > (Updated May 27, 2016, 4:41 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16743 > https://issues.apache.org/jira/browse/AMBARI-16743 > > > Repository: ambari > > > Description > --- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for RANGER service > scripts in common-services > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py > 2c7bd3c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > 3dc4914 > > Diff: https://reviews.apache.org/r/47965/diff/ > > > Testing > --- > > Hadoop QA added a comment - 3 hours ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12806494/AMBARI-16743.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7015//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7015//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
