Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/#review136841 --- This patch has been committed. Please close this review. - Aravin

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-09 Thread Sriharsha Chintalapani
> On June 7, 2016, 6:07 a.m., Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine grained?

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-09 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/#review136767 --- Ship it! Ship It! - Sriharsha Chintalapani On June 9, 2016,

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-08 Thread Jungtaek Lim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/ --- (Updated 6 9, 2016, 1:58 오전) Review request for Ambari, Aravindan Vijayan, Srih

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-07 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/#review136579 --- Ship it! Ship It! - Aravindan Vijayan On June 7, 2016, 6:14

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-07 Thread Jungtaek Lim
> On 6 7, 2016, 6:07 오전, Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine grained? Only

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-07 Thread Sriharsha Chintalapani
> On June 7, 2016, 6:07 a.m., Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine grained?

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-07 Thread Aravindan Vijayan
> On June 7, 2016, 6:07 a.m., Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine grained?

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-06 Thread Jungtaek Lim
> On 6 7, 2016, 6:07 오전, Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine grained? Only

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-06 Thread Sid Wagle
> On June 7, 2016, 6:07 a.m., Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine grained?

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/#review136411 --- Changes look good, only thing to consider is the changes to the me

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-06 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/#review136400 --- Ship it! Ship It! - Sriharsha Chintalapani On May 30, 2016,

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-05-30 Thread Jungtaek Lim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/ --- (Updated 5 30, 2016, 8:21 오전) Review request for Ambari, Sriharsha Chintalapani