----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48191/#review136008 -----------------------------------------------------------
Ship it! Ship It! - Zhe (Joe) Wang On June 2, 2016, 11:25 p.m., Xi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48191/ > ----------------------------------------------------------- > > (Updated June 2, 2016, 11:25 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-17021 > https://issues.apache.org/jira/browse/AMBARI-17021 > > > Repository: ambari > > > Description > ------- > > Found a couple inconsistency issues, plus a bug. > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > b759800 > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 4f2812f > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > a992898 > > Diff: https://reviews.apache.org/r/48191/diff/ > > > Testing > ------- > > All UT passed. > > > What is included in this patch: > 1. List of stacks should be active stacks, not all. > 2. As for the filters on Versions page, the placeholder of Name and Version > filter should be in normal weight. > 3. Add a "close icon" at the end of Name and Version filter. > 4. Kill the slight shift when entering text in Name and Version filter. > > > Thanks, > > Xi Wang > >
