Re: Review Request 48338: LogSearch https support.

2016-06-07 Thread Robert Nettleton 


> On June 7, 2016, 1:15 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java,
> >  line 38
> > 
> >
> > It looks like all these properties should be defined in the "LOGSEARCH" 
> > stack definitions in Ambari, so I'd recommend adding them in this patch.
> 
> Oliver Szabo wrote:
> I can add that part after the patch is merged. (in case if everything 
> works fine if these properties are not used)
> 
> Dharmesh Makwana wrote:
> Oliver, logsearch will work fine in http protocol without these 
> properties. You can go ahead and merge it.

Ok, thanks for the clarification, I'll drop this issue, since it looks like the 
Ambari side of things will be handled in a separate patch.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48338/#review136454
---


On June 7, 2016, 1:25 p.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48338/
> ---
> 
> (Updated June 7, 2016, 1:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17092
> https://issues.apache.org/jira/browse/AMBARI-17092
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LogSearch portal should support HTTPS to ensure secure communication
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  2ebf981 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/PropertiesUtil.java
>  f31e8f8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  f477c5a 
> 
> Diff: https://reviews.apache.org/r/48338/diff/
> 
> 
> Testing
> ---
> 
> Setup Logsearch on 3 node cluster and tested the above feature.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 48338: LogSearch https support.

2016-06-07 Thread Dharmesh Makwana 


> On June 7, 2016, 1:15 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java,
> >  line 38
> > 
> >
> > It looks like all these properties should be defined in the "LOGSEARCH" 
> > stack definitions in Ambari, so I'd recommend adding them in this patch.
> 
> Oliver Szabo wrote:
> I can add that part after the patch is merged. (in case if everything 
> works fine if these properties are not used)

Oliver, logsearch will work fine in http protocol without these properties. You 
can go ahead and merge it.


- Dharmesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48338/#review136454
---


On June 7, 2016, 1:25 p.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48338/
> ---
> 
> (Updated June 7, 2016, 1:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17092
> https://issues.apache.org/jira/browse/AMBARI-17092
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LogSearch portal should support HTTPS to ensure secure communication
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  2ebf981 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/PropertiesUtil.java
>  f31e8f8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  f477c5a 
> 
> Diff: https://reviews.apache.org/r/48338/diff/
> 
> 
> Testing
> ---
> 
> Setup Logsearch on 3 node cluster and tested the above feature.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 48338: LogSearch https support.

2016-06-07 Thread Dharmesh Makwana 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48338/
---

(Updated June 7, 2016, 1:25 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

Fixed typo.


Bugs: AMBARI-17092
https://issues.apache.org/jira/browse/AMBARI-17092


Repository: ambari


Description
---

LogSearch portal should support HTTPS to ensure secure communication


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 2ebf981 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/PropertiesUtil.java
 f31e8f8 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
 f477c5a 

Diff: https://reviews.apache.org/r/48338/diff/


Testing
---

Setup Logsearch on 3 node cluster and tested the above feature.


Thanks,

Dharmesh Makwana