Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-15 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48589/#review137800 --- Ship it! Ship It! - Oliver Szabo On June 14, 2016, 2:15

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48589/#review137632 --- Ship it! Ship It! - Jonathan Hurley On June 14, 2016, 10:15

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-14 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48589/ --- (Updated June 14, 2016, 2:15 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48589/#review137494 --- I don't think we need to special case this. Consider the alert

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48589/ --- (Updated June 13, 2016, 2:21 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-12 Thread Jonathan Hurley
> On June 12, 2016, 7:06 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py, lines > > 410-411 > > > > > > This still seems like a warning which we want. It means that

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-12 Thread Miklos Gergely
> On June 12, 2016, 11:06 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py, lines > > 410-411 > > > > > > This still seems like a warning which we want. It means that

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-12 Thread Miklos Gergely
> On June 12, 2016, 11:06 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py, lines > > 410-411 > > > > > > This still seems like a warning which we want. It means that

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-12 Thread Jonathan Hurley
> On June 12, 2016, 7:06 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py, lines > > 410-411 > > > > > > This still seems like a warning which we want. It means that

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-12 Thread Miklos Gergely
> On June 12, 2016, 11:06 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py, lines > > 410-411 > > > > > > This still seems like a warning which we want. It means that

Re: Review Request 48589: Fix HA enabled logic in the alerts

2016-06-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48589/#review137164 --- ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py