Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable

2016-07-05 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/#review140861
---


Ship it!




Ship It!

- Sid Wagle


On July 5, 2016, 4:38 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48628/
> ---
> 
> (Updated July 5, 2016, 4:38 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17184
> https://issues.apache.org/jira/browse/AMBARI-17184
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When we wanted to restart HBase, we got an error
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
>  line 159, in 
> HbaseMaster().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 686, in restart
> self.start(env, upgrade_type=upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
>  line 86, in start
> self.configure(env) # for security
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
>  line 41, in configure
> hbase(name='master')
>   File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
> line 89, in thunk
> return fn(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
>  line 166, in hbase
> tag = 'GANGLIA-MASTER' if name == 'master' else 'GANGLIA-RS'
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
>  line 233, in hbase_TemplateConfig
> template_tag = tag
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
> line 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/template_config.py",
>  line 46, in action_create
> content = Template(template_name, 
> extra_imports=self.resource.extra_imports)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
> line 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 123, in action_create
> content = self._get_content()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 160, in _get_content
> return content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
> line 51, in __call__
> return self.get_content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
> line 142, in get_content
> rendered = self.template.render(self.context)
>   File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line 
> 891, in render
> return self.environment.handle_exception(exc_info, True)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2",
>  line 76, in top-level template code
> hbase.sink.timeline.truststore.password = {{metric_truststore_password}}
> ambari_jinja2.exceptions.UndefinedError: 'metric_collector_hosts' is undefined
> ```
> 
> 
> We should define metric_collector_hosts in 
> ambari/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  6d304d4 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
>  dcec3d4 
> 
> Diff: https://reviews.apache.org/r/48628/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test && manual test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable

2016-07-04 Thread Masahiro Tanaka 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/
---

(Updated July 5, 2016, 4:38 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.


Changes
---

Update the patch


Bugs: AMBARI-17184
https://issues.apache.org/jira/browse/AMBARI-17184


Repository: ambari


Description
---

When we wanted to restart HBase, we got an error
```
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
 line 159, in 
HbaseMaster().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 257, in execute
method(env)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 686, in restart
self.start(env, upgrade_type=upgrade_type)
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
 line 86, in start
self.configure(env) # for security
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
 line 41, in configure
hbase(name='master')
  File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
line 89, in thunk
return fn(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
 line 166, in hbase
tag = 'GANGLIA-MASTER' if name == 'master' else 'GANGLIA-RS'
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
 line 233, in hbase_TemplateConfig
template_tag = tag
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/template_config.py",
 line 46, in action_create
content = Template(template_name, extra_imports=self.resource.extra_imports)
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 123, in action_create
content = self._get_content()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 160, in _get_content
return content()
  File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
line 51, in __call__
return self.get_content()
  File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
line 142, in get_content
rendered = self.template.render(self.context)
  File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line 
891, in render
return self.environment.handle_exception(exc_info, True)
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2",
 line 76, in top-level template code
hbase.sink.timeline.truststore.password = {{metric_truststore_password}}
ambari_jinja2.exceptions.UndefinedError: 'metric_collector_hosts' is undefined
```


We should define metric_collector_hosts in 
ambari/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 6d304d4 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
 dcec3d4 

Diff: https://reviews.apache.org/r/48628/diff/


Testing
---

mvn clean test && manual test


Thanks,

Masahiro Tanaka

Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable

2016-06-27 Thread Masahiro Tanaka 


> On June 28, 2016, 2:52 a.m., Sid Wagle wrote:
> > hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 Should also be change to use 
> > the comma separated host:port field.

Thank you for reviewing! I'll update the patch in a few days.


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/#review139719
---


On June 13, 2016, 10:24 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48628/
> ---
> 
> (Updated June 13, 2016, 10:24 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17184
> https://issues.apache.org/jira/browse/AMBARI-17184
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When we wanted to restart HBase, we got an error
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
>  line 159, in 
> HbaseMaster().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 686, in restart
> self.start(env, upgrade_type=upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
>  line 86, in start
> self.configure(env) # for security
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
>  line 41, in configure
> hbase(name='master')
>   File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
> line 89, in thunk
> return fn(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
>  line 166, in hbase
> tag = 'GANGLIA-MASTER' if name == 'master' else 'GANGLIA-RS'
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
>  line 233, in hbase_TemplateConfig
> template_tag = tag
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
> line 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/template_config.py",
>  line 46, in action_create
> content = Template(template_name, 
> extra_imports=self.resource.extra_imports)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
> line 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 123, in action_create
> content = self._get_content()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 160, in _get_content
> return content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
> line 51, in __call__
> return self.get_content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
> line 142, in get_content
> rendered = self.template.render(self.context)
>   File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line 
> 891, in render
> return self.environment.handle_exception(exc_info, True)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2",
>  line 76, in top-level template code
> hbase.sink.timeline.truststore.password = {{metric_truststore_password}}
> ambari_jinja2.exceptions.UndefinedError: 'metric_collector_hosts' is undefined
> ```
> 
> 
> We should define metric_collector_hosts in 
> ambari/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  05bad1c 
> 
> Diff: https://reviews.apache.org/r/48628/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test && manual test
> 
> 
> Thanks,
> 
>

Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable

2016-06-27 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/#review139719
---



hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 Should also be change to use the 
comma separated host:port field.

- Sid Wagle


On June 13, 2016, 10:24 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48628/
> ---
> 
> (Updated June 13, 2016, 10:24 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17184
> https://issues.apache.org/jira/browse/AMBARI-17184
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When we wanted to restart HBase, we got an error
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
>  line 159, in 
> HbaseMaster().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 686, in restart
> self.start(env, upgrade_type=upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
>  line 86, in start
> self.configure(env) # for security
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
>  line 41, in configure
> hbase(name='master')
>   File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
> line 89, in thunk
> return fn(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
>  line 166, in hbase
> tag = 'GANGLIA-MASTER' if name == 'master' else 'GANGLIA-RS'
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
>  line 233, in hbase_TemplateConfig
> template_tag = tag
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
> line 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/template_config.py",
>  line 46, in action_create
> content = Template(template_name, 
> extra_imports=self.resource.extra_imports)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
> line 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 123, in action_create
> content = self._get_content()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 160, in _get_content
> return content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
> line 51, in __call__
> return self.get_content()
>   File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
> line 142, in get_content
> rendered = self.template.render(self.context)
>   File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line 
> 891, in render
> return self.environment.handle_exception(exc_info, True)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2",
>  line 76, in top-level template code
> hbase.sink.timeline.truststore.password = {{metric_truststore_password}}
> ambari_jinja2.exceptions.UndefinedError: 'metric_collector_hosts' is undefined
> ```
> 
> 
> We should define metric_collector_hosts in 
> ambari/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  05bad1c 
> 
> Diff: https://reviews.apache.org/r/48628/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test && manual test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>