Re: Review Request 48634: File browser : File preview show first character only when ssl is enabled.

2016-06-13 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48634/#review137454
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 13, 2016, 1:18 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48634/
> ---
> 
> (Updated June 13, 2016, 1:18 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17194
> https://issues.apache.org/jira/browse/AMBARI-17194
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Using IOUtils.read to read from file.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java
>  3585516 
> 
> Diff: https://reviews.apache.org/r/48634/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>



Re: Review Request 48634: File browser : File preview show first character only when ssl is enabled.

2016-06-13 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48634/#review137452
---


Ship it!




Ship It!

- Nitiraj Rathore


On June 13, 2016, 1:18 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48634/
> ---
> 
> (Updated June 13, 2016, 1:18 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17194
> https://issues.apache.org/jira/browse/AMBARI-17194
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Using IOUtils.read to read from file.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java
>  3585516 
> 
> Diff: https://reviews.apache.org/r/48634/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>



Re: Review Request 48634: File browser : File preview show first character only when ssl is enabled.

2016-06-13 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48634/
---

(Updated June 13, 2016, 1:18 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17194
https://issues.apache.org/jira/browse/AMBARI-17194


Repository: ambari


Description
---

Using IOUtils.read to read from file.


Diffs (updated)
-

  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java
 3585516 

Diff: https://reviews.apache.org/r/48634/diff/


Testing
---

Manually Tested


Thanks,

Gaurav Nagar