Re: Review Request 48727: Log Search default log levels can not be altered

2016-06-17 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48727/
---

(Updated June 17, 2016, 10:35 p.m.)


Review request for Ambari, Don Bosco Durai, Dharmesh Makwana, Oliver Szabo, 
Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-17254
https://issues.apache.org/jira/browse/AMBARI-17254


Repository: ambari


Description (updated)
---

The default log levels (log levels to include) can not be altered, forever the 
ones set during the installation (more precisely: the one which is the value of 
the property during the first run of the portal) would be in effect.

To reflect this the property was made editable only at install.


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
 53fc8f4 

Diff: https://reviews.apache.org/r/48727/diff/


Testing
---

Tested on local cluster.


Thanks,

Miklos Gergely

Re: Review Request 48727: Log Search default log levels can not be altered

2016-06-15 Thread Don Bosco Durai 


> On June 15, 2016, 7:38 p.m., Don Bosco Durai wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java,
> >  line 133
> > 
> >
> > Not sure I understood this use case. The defaults from the properties 
> > is only used for bootstraping values in the Solr. Once it is in the Solr, 
> > users might change the default values via LogSearch UI. If we overwrite the 
> > values in Solr on each startup, then any user changes will be lost.
> > 
> > I assume, this requirement is coming due to support for new services 
> > that could be added later. If so, we might have to change the logic for 
> > bootstraping the initial values.
> > 
> > If this is the case, we might have to discuss more.
> 
> Miklos Gergely wrote:
> logsearch.logfeeder.include.default.level can be modified on ambari after 
> Log Search was installed. In this case the user would expect to see the 
> effect of this modification. As I see there are 3 ways to solve this:
> 
> 1. Allow the users to modify the config only by altering 
> logsearch.logfeeder.include.default.level
> 2. Allow the users to modify the config only on the LogSearch UI, and 
> remove logsearch.logfeeder.include.default.level from the property list, and 
> the bootstrap should be done with some constant
> 3. If there is a way to make logsearch.logfeeder.include.default.level 
> unmodifiable after the installation is done, then this would fix the issue too

I would prefer option #3, because I feel in some environment they want all 
logs. Is it possible to do it?


- Don Bosco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48727/#review137811
---


On June 15, 2016, 12:46 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48727/
> ---
> 
> (Updated June 15, 2016, 12:46 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Dharmesh Makwana, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17254
> https://issues.apache.org/jira/browse/AMBARI-17254
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The default log levels (log levels to include) can not be altered, forever 
> the ones set during the installation (more precisely: the one which is the 
> value of the property during the first run of the portal) would be in effect.
> 
> Currently the portal checks if there is a configuration, and does nothing if 
> there is. After this change it will remove any existing configuration upon 
> starting, and replace it with a newly generated configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  147e148 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  edf1dcc 
> 
> Diff: https://reviews.apache.org/r/48727/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48727: Log Search default log levels can not be altered

2016-06-15 Thread Miklos Gergely 


> On June 15, 2016, 7:38 p.m., Don Bosco Durai wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java,
> >  line 133
> > 
> >
> > Not sure I understood this use case. The defaults from the properties 
> > is only used for bootstraping values in the Solr. Once it is in the Solr, 
> > users might change the default values via LogSearch UI. If we overwrite the 
> > values in Solr on each startup, then any user changes will be lost.
> > 
> > I assume, this requirement is coming due to support for new services 
> > that could be added later. If so, we might have to change the logic for 
> > bootstraping the initial values.
> > 
> > If this is the case, we might have to discuss more.

logsearch.logfeeder.include.default.level can be modified on ambari after Log 
Search was installed. In this case the user would expect to see the effect of 
this modification. As I see there are 3 ways to solve this:

1. Allow the users to modify the config only by altering 
logsearch.logfeeder.include.default.level
2. Allow the users to modify the config only on the LogSearch UI, and remove 
logsearch.logfeeder.include.default.level from the property list, and the 
bootstrap should be done with some constant
3. If there is a way to make logsearch.logfeeder.include.default.level 
unmodifiable after the installation is done, then this would fix the issue too


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48727/#review137811
---


On June 15, 2016, 12:46 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48727/
> ---
> 
> (Updated June 15, 2016, 12:46 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Dharmesh Makwana, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17254
> https://issues.apache.org/jira/browse/AMBARI-17254
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The default log levels (log levels to include) can not be altered, forever 
> the ones set during the installation (more precisely: the one which is the 
> value of the property during the first run of the portal) would be in effect.
> 
> Currently the portal checks if there is a configuration, and does nothing if 
> there is. After this change it will remove any existing configuration upon 
> starting, and replace it with a newly generated configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  147e148 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  edf1dcc 
> 
> Diff: https://reviews.apache.org/r/48727/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48727: Log Search default log levels can not be altered

2016-06-15 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48727/#review137746
---


Ship it!




Ship It!

- Robert Nettleton


On June 15, 2016, 12:46 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48727/
> ---
> 
> (Updated June 15, 2016, 12:46 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Dharmesh Makwana, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17254
> https://issues.apache.org/jira/browse/AMBARI-17254
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The default log levels (log levels to include) can not be altered, forever 
> the ones set during the installation (more precisely: the one which is the 
> value of the property during the first run of the portal) would be in effect.
> 
> Currently the portal checks if there is a configuration, and does nothing if 
> there is. After this change it will remove any existing configuration upon 
> starting, and replace it with a newly generated configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  147e148 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  edf1dcc 
> 
> Diff: https://reviews.apache.org/r/48727/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>