Re: Review Request 48766: MySQL service status needs to be more robust

2016-08-05 Thread Juanjo Marron
> On Aug. 3, 2016, 12:33 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 36 > > > > > > What happens if pid_file is Non

Re: Review Request 48766: MySQL service status needs to be more robust

2016-08-05 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/ --- (Updated Aug. 5, 2016, 9:49 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 48766: MySQL service status needs to be more robust

2016-08-03 Thread Juanjo Marron
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if (i

Re: Review Request 48766: MySQL service status needs to be more robust

2016-08-03 Thread Andrew Onischuk
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if (i

Re: Review Request 48766: MySQL service status needs to be more robust

2016-08-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/#review144569 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Re: Review Request 48766: MySQL service status needs to be more robust

2016-08-02 Thread Juanjo Marron
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if (i

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-17 Thread Juanjo Marron
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if (i

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-17 Thread Andrew Onischuk
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if (i

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Juanjo Marron
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if (i

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if (i

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > > > > > Else should go into for, not if (i

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/#review138115 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Juanjo Marron
> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 54 > > > > > > We should probably do a checked_ca

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/ --- (Updated June 16, 2016, 9:20 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 54 > > > > > > We should probably do a checked_ca

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Juanjo Marron
> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 54 > > > > > > We should probably do a checked_ca

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Juanjo Marron
> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 54 > > > > > > We should probably do a checked_ca

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/#review137885 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48766/#review137881 --- Ship it! Ship It! - Alejandro Fernandez On June 15, 2016, 10