----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48840/#review140197 -----------------------------------------------------------
Ship it! Ship It! - Aravindan Vijayan On June 17, 2016, 6:23 a.m., Jungtaek Lim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48840/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 6:23 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid > Wagle. > > > Bugs: AMBARI-17249 > https://issues.apache.org/jira/browse/AMBARI-17249 > > > Repository: ambari > > > Description > ------- > > Background: SystemBolt is reserved component for each worker which exposes > worker level metrics like Memory, GC, and uptime, and so on. > > All SystemBolts have -1 as task id, so identifying SystemBolt components to > task id as same as normal components will fail. Since each worker is > identified by (worker host, port) pair, we can add hostname and port to > metric name to make metric name unique. > > Since it's only for SystemBolt, instead of adding hostname and port to all of > metrics, we can add these to specific metrics which are coming from > SystemBolt. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java > eb572b3 > > ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java > c4b54b4 > > Diff: https://reviews.apache.org/r/48840/diff/ > > > Testing > ------- > > mvn test succeed > applied and tested manually (via 2.4 branch) > > > Thanks, > > Jungtaek Lim > >
