----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48850/#review138216 -----------------------------------------------------------
Ship it! Ship It! - Oleg Nechiporenko On June 17, 2016, 1:44 p.m., Aleksandr Kovalenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48850/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 1:44 p.m.) > > > Review request for Ambari, Andrii Tkach, Oleg Nechiporenko, and Sumit Gupta. > > > Bugs: AMBARI-17195 > https://issues.apache.org/jira/browse/AMBARI-17195 > > > Repository: ambari > > > Description > ------- > > When using Knox's AMBARIUI service to proxy the Ambari service's UI, the > various 'views' don't render. The rest of the UI around management of > services works correctly. > > > Diffs > ----- > > ambari-admin/src/main/resources/ui/admin-web/app/index.html 25379c1 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js b658fb0 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewUrlCtrl.js > 4a663c4 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewUrlEditCtrl.js > 93edc69 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js > 7bb4039 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js > 2878f88 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 8b697f8 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > 6fe46dc > ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 96bcb4c > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html > f6facb5 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html > 4654147 > ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html > 2649eb0 > ambari-admin/src/main/resources/ui/admin-web/app/views/main.html f9e6e63 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > 10d4a82 > ambari-web/app/config.js fe970b1 > ambari-web/app/router.js a057215 > ambari-web/app/routes/views.js c50690c > ambari-web/app/views/main/admin/stack_upgrade/versions_view.js bdf8d7d > > Diff: https://reviews.apache.org/r/48850/diff/ > > > Testing > ------- > > Manually tested. > > ambari-web unit tests: > 28636 tests complete (34 seconds) > 154 tests pending > ambari-admin unit tests: > PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.347 secs / 0.538 > secs) > > > Thanks, > > Aleksandr Kovalenko > >
