Re: Review Request 48970: Follow up NiFi log changes in the LogFeeder config

2016-06-21 Thread Jayush Luniya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48970/#review138863
---


Ship it!




Ship It!

- Jayush Luniya


On June 20, 2016, 11:19 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48970/
> ---
> 
> (Updated June 20, 2016, 11:19 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Oliver Szabo.
> 
> 
> Bugs: AMBARI-17323
> https://issues.apache.org/jira/browse/AMBARI-17323
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The NiFi service log dir properties were recently changes. The LogFeeder 
> config needs to follow up this change to access the NiFi logs
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
>  71a4c1c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  5afc04c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
>  1bbab20 
> 
> Diff: https://reviews.apache.org/r/48970/diff/
> 
> 
> Testing
> ---
> 
> Tested on GCE cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Re: Review Request 48970: Follow up NiFi log changes in the LogFeeder config

2016-06-20 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48970/#review138712
---


Ship it!




Ship It!

- Oliver Szabo


On June 20, 2016, 11:19 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48970/
> ---
> 
> (Updated June 20, 2016, 11:19 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Oliver Szabo.
> 
> 
> Bugs: AMBARI-17323
> https://issues.apache.org/jira/browse/AMBARI-17323
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The NiFi service log dir properties were recently changes. The LogFeeder 
> config needs to follow up this change to access the NiFi logs
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
>  71a4c1c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  5afc04c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
>  1bbab20 
> 
> Diff: https://reviews.apache.org/r/48970/diff/
> 
> 
> Testing
> ---
> 
> Tested on GCE cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Re: Review Request 48970: Follow up NiFi log changes in the LogFeeder config

2016-06-20 Thread Miklos Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48970/
---

(Updated June 20, 2016, 11:19 p.m.)


Review request for Ambari, Jayush Luniya and Oliver Szabo.


Changes
---

Remove test fix, it will be in another patch.


Bugs: AMBARI-17323
https://issues.apache.org/jira/browse/AMBARI-17323


Repository: ambari


Description
---

The NiFi service log dir properties were recently changes. The LogFeeder config 
needs to follow up this change to access the NiFi logs


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
 71a4c1c 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 5afc04c 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
 1bbab20 

Diff: https://reviews.apache.org/r/48970/diff/


Testing
---

Tested on GCE cluster.


Thanks,

Miklos Gergely



Re: Review Request 48970: Follow up NiFi log changes in the LogFeeder config

2016-06-20 Thread Miklos Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48970/
---

(Updated June 20, 2016, 10:37 p.m.)


Review request for Ambari, Jayush Luniya and Oliver Szabo.


Changes
---

Modified HadoopServiceConfig.json accordingly, added fix for some failing Log 
Search unit tests too.


Bugs: AMBARI-17323
https://issues.apache.org/jira/browse/AMBARI-17323


Repository: ambari


Description
---

The NiFi service log dir properties were recently changes. The LogFeeder config 
needs to follow up this change to access the NiFi logs


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/HadoopServiceConfig.json
 71a4c1c 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 5afc04c 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
 1bbab20 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 10e4660 

Diff: https://reviews.apache.org/r/48970/diff/


Testing
---

Tested on GCE cluster.


Thanks,

Miklos Gergely