----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49026/#review138850 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Червень 21, 2016, 3:19 після полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49026/ > ----------------------------------------------------------- > > (Updated Червень 21, 2016, 3:19 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-17339 > https://issues.apache.org/jira/browse/AMBARI-17339 > > > Repository: ambari > > > Description > ------- > > The "NameNode Last Checkpoint" alert is implemented in > _alert_checkpoint_time.py_. This script uses the value of **dfs.namenode.http- > address** property for querying the last checkpoint timestamp. > > This works fine when the NN is not in HA mode. However when NN is in HA mode > this property is either not defined or might not be pointing to the right NN > instance. > > The script needs to be improved such as to figure out if the NN is in HA mode. > If it's in HA mode do not use **dfs.namenode.http-address** property but > rather determine the correct URL to connect to similarly as how it's done in > the _alert_ha_namenode_health.py_ > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py > ca36e62 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_checkpoint_time.py > cb0d49e > > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_checkpoint_time.py > 26b3b9c > > Diff: https://reviews.apache.org/r/49026/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
