Re: Review Request 49162: Update Zeppelin service definition

2016-06-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/#review140026
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 203)


Use os.path.join



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 204)


Use a try except and always close the file in the finally block



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 (line 144)


Just check for len > 0



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 (line 148)


We should really give these default values right before the if-block to 
make sure if anyone refactors this code that these variables are always 
initialized


- Alejandro Fernandez


On June 28, 2016, 5:28 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49162/
> ---
> 
> (Updated June 28, 2016, 5:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17406
> https://issues.apache.org/jira/browse/AMBARI-17406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - comment session manager config in shiro.ini
> - fix default value for zeppelin kerberos properties
> - extract kerberos config update to a new function
> - prevent overwriting interpreter config
> - set default value for spark and livy master
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  844ae98 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  f2899d0 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  770f8f5 
> 
> Diff: https://reviews.apache.org/r/49162/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 49162: Update Zeppelin service definition

2016-06-29 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/#review139970
---


Ship it!




Ship It!

- Prabhjyot Singh


On June 28, 2016, 5:28 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49162/
> ---
> 
> (Updated June 28, 2016, 5:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17406
> https://issues.apache.org/jira/browse/AMBARI-17406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - comment session manager config in shiro.ini
> - fix default value for zeppelin kerberos properties
> - extract kerberos config update to a new function
> - prevent overwriting interpreter config
> - set default value for spark and livy master
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  844ae98 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  f2899d0 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  770f8f5 
> 
> Diff: https://reviews.apache.org/r/49162/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 49162: Update Zeppelin service definition

2016-06-28 Thread Renjith Kamath 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/
---

(Updated June 28, 2016, 5:28 p.m.)


Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, 
Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-17406
https://issues.apache.org/jira/browse/AMBARI-17406


Repository: ambari


Description
---

- comment session manager config in shiro.ini
- fix default value for zeppelin kerberos properties
- extract kerberos config update to a new function
- prevent overwriting interpreter config
- set default value for spark and livy master


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
 844ae98 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 f2899d0 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 770f8f5 

Diff: https://reviews.apache.org/r/49162/diff/


Testing
---

manually tested on CentOS


Thanks,

Renjith Kamath

Re: Review Request 49162: Update Zeppelin service definition

2016-06-28 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/#review139803
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 232)


After latest version of zeppelin we will need following 
notebook['properties']['hive.url'] = 'jdbc:hive2://' +\
 
params.hive_server_host +\
 ':' + 
params.hive_server_port
notebook['properties']['phoenix.url'] = "jdbc:phoenix:" +\
 
params.hbase_zookeeper_quorum + ':' +\
 
params.zookeeper_znode_parent
 
notebook['dependencies'] = []
notebook['dependencies'].append(
  {"groupArtifactVersion": "org.apache.hive:hive-jdbc:2.0.1", 
"local": "false"})
notebook['dependencies'].append(
  {"groupArtifactVersion": 
"org.apache.hadoop:hadoop-common:2.7.2", "local": "false"})
notebook['dependencies'].append(
  {"groupArtifactVersion": 
"org.apache.phoenix:phoenix-core:4.4.0-HBase-1.0", "local": "false"})


- Prabhjyot Singh


On June 23, 2016, 7:07 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49162/
> ---
> 
> (Updated June 23, 2016, 7:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17406
> https://issues.apache.org/jira/browse/AMBARI-17406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - comment session manager config in shiro.ini
> - fix default value for zeppelin kerberos properties
> - extract kerberos config update to a new function
> - prevent overwriting interpreter config
> - set default value for spark and livy master
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  844ae98 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  f2899d0 
> 
> Diff: https://reviews.apache.org/r/49162/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 49162: Update Zeppelin service definition

2016-06-24 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/#review139374
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On June 23, 2016, 7:07 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49162/
> ---
> 
> (Updated June 23, 2016, 7:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17406
> https://issues.apache.org/jira/browse/AMBARI-17406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - comment session manager config in shiro.ini
> - fix default value for zeppelin kerberos properties
> - extract kerberos config update to a new function
> - prevent overwriting interpreter config
> - set default value for spark and livy master
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  844ae98 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  f2899d0 
> 
> Diff: https://reviews.apache.org/r/49162/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 49162: Update Zeppelin service definition

2016-06-23 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/#review139343
---


Ship it!




Ship It!

- Prabhjyot Singh


On June 23, 2016, 7:07 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49162/
> ---
> 
> (Updated June 23, 2016, 7:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17406
> https://issues.apache.org/jira/browse/AMBARI-17406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - comment session manager config in shiro.ini
> - fix default value for zeppelin kerberos properties
> - extract kerberos config update to a new function
> - prevent overwriting interpreter config
> - set default value for spark and livy master
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  844ae98 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  f2899d0 
> 
> Diff: https://reviews.apache.org/r/49162/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>