Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/#review139635 --- Ship it! Ship It! - Srimanth Gunturi On June 27, 2016, 11:20 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49193/ > --- > > (Updated June 27, 2016, 11:20 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam > Borad, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-16756 > https://issues.apache.org/jira/browse/AMBARI-16756 > > > Repository: ambari > > > Description > --- > > Updated ambari Ranger and Ranger KMS code for stop and status call from stack > 2.5 onwards > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > be2a4c8 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > 3187971 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > ab5be74 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > 0d9ce5f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > 8313b18 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > ad0ac60 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py > 6cb69fb > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 5847984 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > 9360e70 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 452be86 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 574264e > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml > ae45552 > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/49193/diff/ > > > Testing > --- > > Testes Ranger and Ranger KMS on centos 6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/#review139617 --- Ship it! Ship It! - Alejandro Fernandez On June 27, 2016, 11:20 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49193/ > --- > > (Updated June 27, 2016, 11:20 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam > Borad, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-16756 > https://issues.apache.org/jira/browse/AMBARI-16756 > > > Repository: ambari > > > Description > --- > > Updated ambari Ranger and Ranger KMS code for stop and status call from stack > 2.5 onwards > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > be2a4c8 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > 3187971 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > ab5be74 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > 0d9ce5f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > 8313b18 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > ad0ac60 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py > 6cb69fb > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 5847984 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > 9360e70 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 452be86 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 574264e > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml > ae45552 > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/49193/diff/ > > > Testing > --- > > Testes Ranger and Ranger KMS on centos 6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/ --- (Updated June 27, 2016, 11:20 a.m.) Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, Srimanth Gunturi, and Velmurugan Periasamy. Bugs: AMBARI-16756 https://issues.apache.org/jira/browse/AMBARI-16756 Repository: ambari Description --- Updated ambari Ranger and Ranger KMS code for stop and status call from stack 2.5 onwards Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/constants.py be2a4c8 ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 3187971 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ab5be74 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 0d9ce5f ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 8313b18 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py ad0ac60 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py 6cb69fb ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 5847984 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 9360e70 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 452be86 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/status_params.py PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 574264e ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml ae45552 ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py PRE-CREATION ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py PRE-CREATION ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py PRE-CREATION ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json PRE-CREATION ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json PRE-CREATION Diff: https://reviews.apache.org/r/49193/diff/ Testing --- Testes Ranger and Ranger KMS on centos 6 Thanks, Mugdha Varadkar
Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/ --- (Updated June 27, 2016, 9:43 a.m.) Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, Srimanth Gunturi, and Velmurugan Periasamy. Changes --- @Alejandro Fernandez added Ranger test for stack 2.5. I have not handle RANGER_KMS test here handling in this https://reviews.apache.org/r/49072/, I am working on it. Till then below is the report. Running tests for stack:2.5 service:RANGER test_configure_default (test_ranger_admin.TestRangerAdmin) ... ok test_configure_secured (test_ranger_admin.TestRangerAdmin) ... ok test_start_default (test_ranger_admin.TestRangerAdmin) ... ok test_stop_default (test_ranger_admin.TestRangerAdmin) ... ok test_configure_default (test_ranger_usersync.TestRangerUsersync) ... ok test_configure_secured (test_ranger_usersync.TestRangerUsersync) ... ok test_start_default (test_ranger_usersync.TestRangerUsersync) ... ok test_stop_default (test_ranger_usersync.TestRangerUsersync) ... ok test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... ok test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok test_start_default (test_ranger_tagsync.TestRangerTagsync) ... ok test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... ok -- Ran 12 tests in 0.306s OK Bugs: AMBARI-16756 https://issues.apache.org/jira/browse/AMBARI-16756 Repository: ambari Description --- Updated ambari Ranger and Ranger KMS code for stop and status call from stack 2.5 onwards Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/constants.py be2a4c8 ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 3187971 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ab5be74 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py 0d9ce5f ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py 8313b18 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py ad0ac60 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py 6cb69fb ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 5847984 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py 9360e70 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 452be86 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/status_params.py PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 574264e ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml ae45552 ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py PRE-CREATION ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py PRE-CREATION ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py PRE-CREATION ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json PRE-CREATION ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json PRE-CREATION Diff: https://reviews.apache.org/r/49193/diff/ Testing --- Testes Ranger and Ranger KMS on centos 6 Thanks, Mugdha Varadkar
Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/#review139391 --- Any unit test changes? Did python unit tests pass? - Alejandro Fernandez On June 24, 2016, 11:53 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49193/ > --- > > (Updated June 24, 2016, 11:53 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam > Borad, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-16756 > https://issues.apache.org/jira/browse/AMBARI-16756 > > > Repository: ambari > > > Description > --- > > Updated ambari Ranger and Ranger KMS code for stop and status call from stack > 2.5 onwards > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > be2a4c8 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > 3187971 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > ab5be74 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > 0d9ce5f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > 8313b18 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > ad0ac60 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py > 6cb69fb > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 5847984 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > 9360e70 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 452be86 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 574264e > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml > ae45552 > > Diff: https://reviews.apache.org/r/49193/diff/ > > > Testing > --- > > Testes Ranger and Ranger KMS on centos 6 > > > Thanks, > > Mugdha Varadkar > >