-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49282/
-----------------------------------------------------------
(Updated June 28, 2016, 5:11 p.m.)
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Summary (updated)
-----------------
AMBARI-17149 : Issues in AMS HadoopTimelineMetricsSink integration with HBase
metric system.
Bugs: AMBARI-17149
https://issues.apache.org/jira/browse/AMBARI-17149
Repository: ambari
Description (updated)
-------
PROBLEM
Following exception is seen in the RS logs during every HBase metrics system
restart
2016-06-24 22:51:11,440 INFO [HBase-Metrics2-1] impl.MetricsConfig: loaded
properties from hadoop-metrics2-hbase.properties
2016-06-24 22:51:11,443 WARN [HBase-Metrics2-1] impl.MetricsSystemImpl: Error
creating sink 'ganglia'
org.apache.hadoop.metrics2.impl.MetricsConfigException: Error creating plugin:
org.apache.hadoop.metrics2.sink.ganglia.GangliaSink31
at
org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:203)
at
org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:529)
at
org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:501)
at
org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:480)
at
org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:189)
at
org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:78)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: Does not contain a valid
host:port authority: :8656
at org.apache.hadoop.net.NetUtils.createSocketAddr(NetUtils.java:213)
at org.apache.hadoop.net.NetUtils.createSocketAddr(NetUtils.java:164)
at org.apache.hadoop.metrics2.util.Servers.parse(Servers.java:61)
at
org.apache.hadoop.metrics2.sink.ganglia.AbstractGangliaSink.init(AbstractGangliaSink.java:135)
at
org.apache.hadoop.metrics2.sink.ganglia.GangliaSink30.init(GangliaSink30.java:59)
at org.apache.hado
BUG
Due to an if-else construct, hadoop-metrics2-hbase.properties was getting
populated with Ganglia Sink properties when AMS is not installed.
FIX
Change such that a cluster can be deployed with either Ganglia or AMS or both.
Diffs
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
5ce2bd5
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
481bafa
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
becfa7a
Diff: https://reviews.apache.org/r/49282/diff/
Testing
-------
Manually tested.
Thanks,
Aravindan Vijayan
