Re: Review Request 49393: Incorrect error message for view URL name and short URL validation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49393/#review142067 --- Hello Sangeeta, Could you please close this one if it has been committed. Thanks. Di - Di Li On June 29, 2016, 7:31 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49393/ > --- > > (Updated June 29, 2016, 7:31 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-16785 > https://issues.apache.org/jira/browse/AMBARI-16785 > > > Repository: ambari > > > Description > --- > > The create url UI flags an error about minimum length required for URL name > being 2 characters even if the URL name specified is 2 characters long. > The create url UI flags an error about maximum length allowed for URL name > being 25 characters when the length of the URL name specified is greater than > 20 characters long. > The create/edit url UI flags an error about minimum length required for short > URL being 2 characters even if the short URL specified is 2 characters long. > > This seems to be because the minimum length for URL name is set to 3 via > ng-minlength="3" instead of 2 as the error message indicates. > Also, the maximum length for URL name is set to 20 via ng-maxlength="20" > instead of 25 as the error message indicates. > Also, the minimum length for short URL is set to 3 via ng-minlength="3" > instead of 2 as the error message indicates. > > Fix involves updating the html files with values that match the error message > displayed. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html > a01024d > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html > 1d0ff8c > > Diff: https://reviews.apache.org/r/49393/diff/ > > > Testing > --- > > Manual testing. > Ran mvn test. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 49393: Incorrect error message for view URL name and short URL validation
> On July 5, 2016, 2:23 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Alexandr. Can you help commit the change. done - Alexandr --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49393/#review140777 --- On June 29, 2016, 7:31 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49393/ > --- > > (Updated June 29, 2016, 7:31 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-16785 > https://issues.apache.org/jira/browse/AMBARI-16785 > > > Repository: ambari > > > Description > --- > > The create url UI flags an error about minimum length required for URL name > being 2 characters even if the URL name specified is 2 characters long. > The create url UI flags an error about maximum length allowed for URL name > being 25 characters when the length of the URL name specified is greater than > 20 characters long. > The create/edit url UI flags an error about minimum length required for short > URL being 2 characters even if the short URL specified is 2 characters long. > > This seems to be because the minimum length for URL name is set to 3 via > ng-minlength="3" instead of 2 as the error message indicates. > Also, the maximum length for URL name is set to 20 via ng-maxlength="20" > instead of 25 as the error message indicates. > Also, the minimum length for short URL is set to 3 via ng-minlength="3" > instead of 2 as the error message indicates. > > Fix involves updating the html files with values that match the error message > displayed. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html > a01024d > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html > 1d0ff8c > > Diff: https://reviews.apache.org/r/49393/diff/ > > > Testing > --- > > Manual testing. > Ran mvn test. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 49393: Incorrect error message for view URL name and short URL validation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49393/#review140777 --- Ship it! Ship It! - Alexandr Antonenko On June 29, 2016, 7:31 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49393/ > --- > > (Updated June 29, 2016, 7:31 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-16785 > https://issues.apache.org/jira/browse/AMBARI-16785 > > > Repository: ambari > > > Description > --- > > The create url UI flags an error about minimum length required for URL name > being 2 characters even if the URL name specified is 2 characters long. > The create url UI flags an error about maximum length allowed for URL name > being 25 characters when the length of the URL name specified is greater than > 20 characters long. > The create/edit url UI flags an error about minimum length required for short > URL being 2 characters even if the short URL specified is 2 characters long. > > This seems to be because the minimum length for URL name is set to 3 via > ng-minlength="3" instead of 2 as the error message indicates. > Also, the maximum length for URL name is set to 20 via ng-maxlength="20" > instead of 25 as the error message indicates. > Also, the minimum length for short URL is set to 3 via ng-minlength="3" > instead of 2 as the error message indicates. > > Fix involves updating the html files with values that match the error message > displayed. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html > a01024d > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html > 1d0ff8c > > Diff: https://reviews.apache.org/r/49393/diff/ > > > Testing > --- > > Manual testing. > Ran mvn test. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 49393: Incorrect error message for view URL name and short URL validation
> On June 29, 2016, 7:35 p.m., Di Li wrote: > > Ship It! Thanks Di. Hi Alexander, can you please review the changes? Thanks, Sangeeta - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49393/#review140043 --- On June 29, 2016, 7:31 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49393/ > --- > > (Updated June 29, 2016, 7:31 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-16785 > https://issues.apache.org/jira/browse/AMBARI-16785 > > > Repository: ambari > > > Description > --- > > The create url UI flags an error about minimum length required for URL name > being 2 characters even if the URL name specified is 2 characters long. > The create url UI flags an error about maximum length allowed for URL name > being 25 characters when the length of the URL name specified is greater than > 20 characters long. > The create/edit url UI flags an error about minimum length required for short > URL being 2 characters even if the short URL specified is 2 characters long. > > This seems to be because the minimum length for URL name is set to 3 via > ng-minlength="3" instead of 2 as the error message indicates. > Also, the maximum length for URL name is set to 20 via ng-maxlength="20" > instead of 25 as the error message indicates. > Also, the minimum length for short URL is set to 3 via ng-minlength="3" > instead of 2 as the error message indicates. > > Fix involves updating the html files with values that match the error message > displayed. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html > a01024d > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html > 1d0ff8c > > Diff: https://reviews.apache.org/r/49393/diff/ > > > Testing > --- > > Manual testing. > Ran mvn test. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 49393: Incorrect error message for view URL name and short URL validation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49393/#review140043 --- Ship it! Ship It! - Di Li On June 29, 2016, 7:31 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49393/ > --- > > (Updated June 29, 2016, 7:31 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-16785 > https://issues.apache.org/jira/browse/AMBARI-16785 > > > Repository: ambari > > > Description > --- > > The create url UI flags an error about minimum length required for URL name > being 2 characters even if the URL name specified is 2 characters long. > The create url UI flags an error about maximum length allowed for URL name > being 25 characters when the length of the URL name specified is greater than > 20 characters long. > The create/edit url UI flags an error about minimum length required for short > URL being 2 characters even if the short URL specified is 2 characters long. > > This seems to be because the minimum length for URL name is set to 3 via > ng-minlength="3" instead of 2 as the error message indicates. > Also, the maximum length for URL name is set to 20 via ng-maxlength="20" > instead of 25 as the error message indicates. > Also, the minimum length for short URL is set to 3 via ng-minlength="3" > instead of 2 as the error message indicates. > > Fix involves updating the html files with values that match the error message > displayed. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html > a01024d > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html > 1d0ff8c > > Diff: https://reviews.apache.org/r/49393/diff/ > > > Testing > --- > > Manual testing. > Ran mvn test. > > > Thanks, > > Sangeeta Ravindran > >
