Re: Review Request 49510: Zeppelin: remove Livy component dependency

2016-07-01 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49510/#review140392
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 1, 2016, 2:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49510/
> ---
> 
> (Updated July 1, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17523
> https://issues.apache.org/jira/browse/AMBARI-17523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove Livy component dependency from metainfo.xml
> - code clean up
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  4f19b43 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fd6cbb6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  936df81 
> 
> Diff: https://reviews.apache.org/r/49510/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>



Re: Review Request 49510: Zeppelin: remove Livy component dependency

2016-07-01 Thread Renjith Kamath


> On July 1, 2016, 2:29 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py,
> >  line 204
> > 
> >
> > Is this tested in non-root scenarios?
> > You can discuss with Andrew O to see if this will pose an issue for 
> > non-root scenarios.
> 
> Renjith Kamath wrote:
> I'm re-testing this. Earlier this was tested for non-root and was 
> working. Now we have a few permission updates from the package in post 
> install script.

This works fine for non-root user scenarios.


- Renjith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49510/#review140357
---


On July 1, 2016, 2:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49510/
> ---
> 
> (Updated July 1, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17523
> https://issues.apache.org/jira/browse/AMBARI-17523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove Livy component dependency from metainfo.xml
> - code clean up
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  4f19b43 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fd6cbb6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  936df81 
> 
> Diff: https://reviews.apache.org/r/49510/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>



Re: Review Request 49510: Zeppelin: remove Livy component dependency

2016-07-01 Thread Renjith Kamath


> On July 1, 2016, 2:27 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml,
> >  line 42
> > 
> >
> > I understand that this is not honored by UI and only blueprint looks 
> > into this - why should this be removed?

Livy install is going to be handled in the documentation. This is removed for 
consistency.


- Renjith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49510/#review140356
---


On July 1, 2016, 2:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49510/
> ---
> 
> (Updated July 1, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17523
> https://issues.apache.org/jira/browse/AMBARI-17523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove Livy component dependency from metainfo.xml
> - code clean up
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  4f19b43 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fd6cbb6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  936df81 
> 
> Diff: https://reviews.apache.org/r/49510/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>



Re: Review Request 49510: Zeppelin: remove Livy component dependency

2016-07-01 Thread Renjith Kamath


> On July 1, 2016, 2:29 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py,
> >  line 204
> > 
> >
> > Is this tested in non-root scenarios?
> > You can discuss with Andrew O to see if this will pose an issue for 
> > non-root scenarios.

I'm re-testing this. Earlier this was tested for non-root and was working. Now 
we have a few permission updates from the package in post install script.


- Renjith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49510/#review140357
---


On July 1, 2016, 2:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49510/
> ---
> 
> (Updated July 1, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17523
> https://issues.apache.org/jira/browse/AMBARI-17523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove Livy component dependency from metainfo.xml
> - code clean up
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  4f19b43 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fd6cbb6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  936df81 
> 
> Diff: https://reviews.apache.org/r/49510/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>



Re: Review Request 49510: Zeppelin: remove Livy component dependency

2016-07-01 Thread Prabhjyot Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49510/#review140372
---


Ship it!




Ship It!

- Prabhjyot Singh


On July 1, 2016, 2:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49510/
> ---
> 
> (Updated July 1, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17523
> https://issues.apache.org/jira/browse/AMBARI-17523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove Livy component dependency from metainfo.xml
> - code clean up
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  4f19b43 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fd6cbb6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  936df81 
> 
> Diff: https://reviews.apache.org/r/49510/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>



Re: Review Request 49510: Zeppelin: remove Livy component dependency

2016-07-01 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49510/#review140357
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 204)


Is this tested in non-root scenarios?
You can discuss with Andrew O to see if this will pose an issue for 
non-root scenarios.


- Sumit Mohanty


On July 1, 2016, 2:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49510/
> ---
> 
> (Updated July 1, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17523
> https://issues.apache.org/jira/browse/AMBARI-17523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove Livy component dependency from metainfo.xml
> - code clean up
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  4f19b43 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fd6cbb6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  936df81 
> 
> Diff: https://reviews.apache.org/r/49510/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>



Re: Review Request 49510: Zeppelin: remove Livy component dependency

2016-07-01 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49510/#review140356
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 


I understand that this is not honored by UI and only blueprint looks into 
this - why should this be removed?


- Sumit Mohanty


On July 1, 2016, 2:23 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49510/
> ---
> 
> (Updated July 1, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17523
> https://issues.apache.org/jira/browse/AMBARI-17523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove Livy component dependency from metainfo.xml
> - code clean up
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  4f19b43 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fd6cbb6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  936df81 
> 
> Diff: https://reviews.apache.org/r/49510/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>



Re: Review Request 49510: Zeppelin: remove Livy component dependency

2016-07-01 Thread Renjith Kamath

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49510/
---

(Updated July 1, 2016, 2:23 p.m.)


Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, 
Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-17523
https://issues.apache.org/jira/browse/AMBARI-17523


Repository: ambari


Description
---

- remove Livy component dependency from metainfo.xml
- code clean up


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 4f19b43 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 fd6cbb6 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 936df81 

Diff: https://reviews.apache.org/r/49510/diff/


Testing
---

manually tested on CentOS


Thanks,

Renjith Kamath



Re: Review Request 49510: Zeppelin: remove Livy component dependency

2016-07-01 Thread Prabhjyot Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49510/#review140350
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 (line 115)


Since you have already initilized hive_* (line 101-104) properties you 
don't need else condition.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 (line 124)


Same here, this else is also redundant.


- Prabhjyot Singh


On July 1, 2016, 1:52 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49510/
> ---
> 
> (Updated July 1, 2016, 1:52 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17523
> https://issues.apache.org/jira/browse/AMBARI-17523
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove Livy component dependency from metainfo.xml
> - code clean up
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  4f19b43 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fd6cbb6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  936df81 
> 
> Diff: https://reviews.apache.org/r/49510/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>