Re: Review Request 49594: 'Restart all' services fails due to dependency on other service components

[Dmytro Sen]

> On Июль 4, 2016, 3 п.п., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json, 
> > line 46
> > 
> >
> > is this just duplicating 'start' dependencies? Shouldn't we rewrite 
> > restart to use start dependencies?

Will be implemented in a separate jira


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49594/#review140664
---


On Июль 4, 2016, 2:52 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49594/
> ---
> 
> (Updated Июль 4, 2016, 2:52 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-17552
> https://issues.apache.org/jira/browse/AMBARI-17552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Looks like we have a dependency mechanism in place due to which the newly 
> added "Restart all Services" operation does not work as expected in some cases
> Here is my scenario:
> 1. Deploy a cluster (HDP-2.4.2.0) with core services (HDFS, YARN, ZK, MR) and 
> Ambari-2.4.0.0 (ambari-server-2.4.0.0-680.x86_64)
> 2. Add Spark, Hive, Tez, Pig to the cluster and let it finish
> 3. At the end of service addition, there is an icon against HDFS, YARN, MR 
> indicating these three services need restart
> 4. Try 'Restart all Required' operation
> Result:
> Failures at ATS start, which aborts the whole restart operation.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json 
> 710b0dd 
>   ambari-server/src/main/resources/stacks/HDP/2.1/role_command_order.json 
> 3adf5e1 
> 
> Diff: https://reviews.apache.org/r/49594/diff/
> 
> 
> Testing
> ---
> 
> Manual unit tests
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49594: 'Restart all' services fails due to dependency on other service components

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49594/#review140676
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On July 4, 2016, 5:52 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49594/
> ---
> 
> (Updated July 4, 2016, 5:52 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-17552
> https://issues.apache.org/jira/browse/AMBARI-17552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Looks like we have a dependency mechanism in place due to which the newly 
> added "Restart all Services" operation does not work as expected in some cases
> Here is my scenario:
> 1. Deploy a cluster (HDP-2.4.2.0) with core services (HDFS, YARN, ZK, MR) and 
> Ambari-2.4.0.0 (ambari-server-2.4.0.0-680.x86_64)
> 2. Add Spark, Hive, Tez, Pig to the cluster and let it finish
> 3. At the end of service addition, there is an icon against HDFS, YARN, MR 
> indicating these three services need restart
> 4. Try 'Restart all Required' operation
> Result:
> Failures at ATS start, which aborts the whole restart operation.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json 
> 710b0dd 
>   ambari-server/src/main/resources/stacks/HDP/2.1/role_command_order.json 
> 3adf5e1 
> 
> Diff: https://reviews.apache.org/r/49594/diff/
> 
> 
> Testing
> ---
> 
> Manual unit tests
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49594: 'Restart all' services fails due to dependency on other service components

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49594/#review140664
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json (line 
46)


is this just duplicating 'start' dependencies? Shouldn't we rewrite restart 
to use start dependencies?


- Andrew Onischuk


On July 4, 2016, 2:52 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49594/
> ---
> 
> (Updated July 4, 2016, 2:52 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-17552
> https://issues.apache.org/jira/browse/AMBARI-17552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Looks like we have a dependency mechanism in place due to which the newly 
> added "Restart all Services" operation does not work as expected in some cases
> Here is my scenario:
> 1. Deploy a cluster (HDP-2.4.2.0) with core services (HDFS, YARN, ZK, MR) and 
> Ambari-2.4.0.0 (ambari-server-2.4.0.0-680.x86_64)
> 2. Add Spark, Hive, Tez, Pig to the cluster and let it finish
> 3. At the end of service addition, there is an icon against HDFS, YARN, MR 
> indicating these three services need restart
> 4. Try 'Restart all Required' operation
> Result:
> Failures at ATS start, which aborts the whole restart operation.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json 
> 710b0dd 
>   ambari-server/src/main/resources/stacks/HDP/2.1/role_command_order.json 
> 3adf5e1 
> 
> Diff: https://reviews.apache.org/r/49594/diff/
> 
> 
> Testing
> ---
> 
> Manual unit tests
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49594: 'Restart all' services fails due to dependency on other service components

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49594/#review140662
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Липень 4, 2016, 2:52 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49594/
> ---
> 
> (Updated Липень 4, 2016, 2:52 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-17552
> https://issues.apache.org/jira/browse/AMBARI-17552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Looks like we have a dependency mechanism in place due to which the newly 
> added "Restart all Services" operation does not work as expected in some cases
> Here is my scenario:
> 1. Deploy a cluster (HDP-2.4.2.0) with core services (HDFS, YARN, ZK, MR) and 
> Ambari-2.4.0.0 (ambari-server-2.4.0.0-680.x86_64)
> 2. Add Spark, Hive, Tez, Pig to the cluster and let it finish
> 3. At the end of service addition, there is an icon against HDFS, YARN, MR 
> indicating these three services need restart
> 4. Try 'Restart all Required' operation
> Result:
> Failures at ATS start, which aborts the whole restart operation.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json 
> 710b0dd 
>   ambari-server/src/main/resources/stacks/HDP/2.1/role_command_order.json 
> 3adf5e1 
> 
> Diff: https://reviews.apache.org/r/49594/diff/
> 
> 
> Testing
> ---
> 
> Manual unit tests
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>