Re: Review Request 49745: Retries for logsearch service check

2016-07-07 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49745/#review141169
---


Ship it!




Ship It!

- Sebastian Toader


On July 7, 2016, 5:40 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49745/
> ---
> 
> (Updated July 7, 2016, 5:40 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Miklos Gergely, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-17601
> https://issues.apache.org/jira/browse/AMBARI-17601
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add some retries with sleep for logsearch service.
> If there are just a few services in the cluster, its possiple logsearch wont 
> have enogh time to startup when service_check starts to run
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
>  63344e4 
> 
> Diff: https://reviews.apache.org/r/49745/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 49745: Retries for logsearch service check

2016-07-07 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49745/
---

(Updated July 7, 2016, 3:40 p.m.)


Review request for Ambari, Jayush Luniya, Miklos Gergely, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

- timeout not needed


Bugs: AMBARI-17601
https://issues.apache.org/jira/browse/AMBARI-17601


Repository: ambari


Description
---

Add some retries with sleep for logsearch service.
If there are just a few services in the cluster, its possiple logsearch wont 
have enogh time to startup when service_check starts to run


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 63344e4 

Diff: https://reviews.apache.org/r/49745/diff/


Testing
---

Total run:1014
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 49745: Retries for logsearch service check

2016-07-07 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49745/#review141146
---


Ship it!




Ship It!

- Miklos Gergely


On July 7, 2016, 8:29 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49745/
> ---
> 
> (Updated July 7, 2016, 8:29 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Miklos Gergely, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-17601
> https://issues.apache.org/jira/browse/AMBARI-17601
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add some retries with sleep for logsearch service.
> If there are just a few services in the cluster, its possiple logsearch wont 
> have enogh time to startup when service_check starts to run
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
>  63344e4 
> 
> Diff: https://reviews.apache.org/r/49745/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 49745: Retries for logsearch service check

2016-07-07 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49745/#review141144
---


Ship it!




Ship It!

- Sebastian Toader


On July 7, 2016, 10:29 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49745/
> ---
> 
> (Updated July 7, 2016, 10:29 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Miklos Gergely, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-17601
> https://issues.apache.org/jira/browse/AMBARI-17601
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add some retries with sleep for logsearch service.
> If there are just a few services in the cluster, its possiple logsearch wont 
> have enogh time to startup when service_check starts to run
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
>  63344e4 
> 
> Diff: https://reviews.apache.org/r/49745/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 49745: Retries for logsearch service check

2016-07-07 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49745/
---

(Updated July 7, 2016, 8:29 a.m.)


Review request for Ambari, Jayush Luniya, Miklos Gergely, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

- increase the number of tries 
- reduce the interval length between tries


Bugs: AMBARI-17601
https://issues.apache.org/jira/browse/AMBARI-17601


Repository: ambari


Description
---

Add some retries with sleep for logsearch service.
If there are just a few services in the cluster, its possiple logsearch wont 
have enogh time to startup when service_check starts to run


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 63344e4 

Diff: https://reviews.apache.org/r/49745/diff/


Testing
---

Total run:1014
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 49745: Retries for logsearch service check

2016-07-07 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49745/#review141143
---




ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 (line 31)


Having in mind the reduction of latency for cluster creation and service 
startup I think it would make sense to increase the number of tries and reduce 
the interval length between tries


- Sebastian Toader


On July 7, 2016, 10:17 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49745/
> ---
> 
> (Updated July 7, 2016, 10:17 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Miklos Gergely, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-17601
> https://issues.apache.org/jira/browse/AMBARI-17601
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add some retries with sleep for logsearch service.
> If there are just a few services in the cluster, its possiple logsearch wont 
> have enogh time to startup when service_check starts to run
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
>  63344e4 
> 
> Diff: https://reviews.apache.org/r/49745/diff/
> 
> 
> Testing
> ---
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>