Re: Review Request 49801: Syntax error in 'setup_ranger_xml.py' logging.

2016-07-08 Thread Andrew Onischuk 


> On July 8, 2016, 11:06 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py,
> >  line 289
> > 
> >
> > I'd replace {{db_name}} in the error message with the value of 
> > {db_flavor}

Done


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49801/#review141270
---


On July 8, 2016, 11:56 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49801/
> ---
> 
> (Updated July 8, 2016, 11:56 a.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-17620
> https://issues.apache.org/jira/browse/AMBARI-17620
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> File "/var/lib/ambari-agent/cache/common-
> services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py", line 291, in
> copy_jdbc_connector  
> Please run 'ambari-server setup --jdbc-db=
> 
> {db_name}
> 
> \--jdbc-driver=
> 
> {path_to_jdbc}
> 
> on server host.'".format(params.db_flavor, params.jdk_location)  
> KeyError: 'db_name'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9dbf6d4 
> 
> Diff: https://reviews.apache.org/r/49801/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49801: Syntax error in 'setup_ranger_xml.py' logging.

2016-07-08 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49801/
---

(Updated July 8, 2016, 11:56 a.m.)


Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-17620
https://issues.apache.org/jira/browse/AMBARI-17620


Repository: ambari


Description
---

File "/var/lib/ambari-agent/cache/common-
services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py", line 291, in
copy_jdbc_connector  
Please run 'ambari-server setup --jdbc-db=

{db_name}

\--jdbc-driver=

{path_to_jdbc}

on server host.'".format(params.db_flavor, params.jdk_location)  
KeyError: 'db_name'


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 9dbf6d4 

Diff: https://reviews.apache.org/r/49801/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 49801: Syntax error in 'setup_ranger_xml.py' logging.

2016-07-08 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49801/#review141271
---


Ship it!




Ship It!

- Sebastian Toader


On July 8, 2016, 12:30 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49801/
> ---
> 
> (Updated July 8, 2016, 12:30 p.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-17620
> https://issues.apache.org/jira/browse/AMBARI-17620
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> File "/var/lib/ambari-agent/cache/common-
> services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py", line 291, in
> copy_jdbc_connector  
> Please run 'ambari-server setup --jdbc-db=
> 
> {db_name}
> 
> \--jdbc-driver=
> 
> {path_to_jdbc}
> 
> on server host.'".format(params.db_flavor, params.jdk_location)  
> KeyError: 'db_name'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9dbf6d4 
> 
> Diff: https://reviews.apache.org/r/49801/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49801: Syntax error in 'setup_ranger_xml.py' logging.

2016-07-08 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49801/#review141270
---




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 (line 289)


I'd replace {{db_name}} in the error message with the value of {db_flavor}


- Sebastian Toader


On July 8, 2016, 12:30 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49801/
> ---
> 
> (Updated July 8, 2016, 12:30 p.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-17620
> https://issues.apache.org/jira/browse/AMBARI-17620
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> File "/var/lib/ambari-agent/cache/common-
> services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py", line 291, in
> copy_jdbc_connector  
> Please run 'ambari-server setup --jdbc-db=
> 
> {db_name}
> 
> \--jdbc-driver=
> 
> {path_to_jdbc}
> 
> on server host.'".format(params.db_flavor, params.jdk_location)  
> KeyError: 'db_name'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9dbf6d4 
> 
> Diff: https://reviews.apache.org/r/49801/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49801: Syntax error in 'setup_ranger_xml.py' logging.

2016-07-08 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49801/#review141267
---


Ship it!




Ship It!

- Dmytro Sen


On Июль 8, 2016, 10:30 д.п., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49801/
> ---
> 
> (Updated Июль 8, 2016, 10:30 д.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-17620
> https://issues.apache.org/jira/browse/AMBARI-17620
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> File "/var/lib/ambari-agent/cache/common-
> services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py", line 291, in
> copy_jdbc_connector  
> Please run 'ambari-server setup --jdbc-db=
> 
> {db_name}
> 
> \--jdbc-driver=
> 
> {path_to_jdbc}
> 
> on server host.'".format(params.db_flavor, params.jdk_location)  
> KeyError: 'db_name'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9dbf6d4 
> 
> Diff: https://reviews.apache.org/r/49801/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>