----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49809/#review141656 -----------------------------------------------------------
Ship it! Ship It! I give you a +1, but logSearchServerRunning method should be renamed later, or the helper should be refactored a bit. - Oliver Szabo On July 8, 2016, 9:59 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49809/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 9:59 p.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17625 > https://issues.apache.org/jira/browse/AMBARI-17625 > > > Repository: ambari > > > Description > ------- > > ambari-server.log contains entries like this if Log Search is not installed: > > 06 Jul 2016 19:26:28,798 ERROR [ambari-client-thread-2843] > LoggingSearchPropertyProvider:59 - Error occurred while making request to > LogSearch service, unable to populate logging properties on this resource > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java > a28e04a > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java > 8b71b65 > > Diff: https://reviews.apache.org/r/49809/diff/ > > > Testing > ------- > > Tested on local cluster > > > Thanks, > > Miklos Gergely > >