Re: Review Request 50083: Storm service check failed during Express Upgrade due to Nimbus going down after restart with CNF IClusterReporter

2016-07-15 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50083/#review142445
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 15, 2016, 8:54 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50083/
> ---
> 
> (Updated July 15, 2016, 8:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17743
> https://issues.apache.org/jira/browse/AMBARI-17743
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Recent code changed how the storm/legacy-storm jars are determined.  This fix 
> uses the stack feature to determine that instead of hard-coding a check 
> against a version string.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  5b9e900 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  9c24f48 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  dfd55dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  7f69fcd 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 04ed17b 
> 
> Diff: https://reviews.apache.org/r/50083/diff/
> 
> 
> Testing
> ---
> 
> Manual + Automated
> 
> --
> Total run:1019
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 50083: Storm service check failed during Express Upgrade due to Nimbus going down after restart with CNF IClusterReporter

2016-07-15 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50083/#review142444
---


Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 (line 97)


MODERN is a bit vague ... would "APACHE" be better?


- Jonathan Hurley


On July 15, 2016, 4:54 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50083/
> ---
> 
> (Updated July 15, 2016, 4:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17743
> https://issues.apache.org/jira/browse/AMBARI-17743
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Recent code changed how the storm/legacy-storm jars are determined.  This fix 
> uses the stack feature to determine that instead of hard-coding a check 
> against a version string.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  5b9e900 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  9c24f48 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  dfd55dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  7f69fcd 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 04ed17b 
> 
> Diff: https://reviews.apache.org/r/50083/diff/
> 
> 
> Testing
> ---
> 
> Manual + Automated
> 
> --
> Total run:1019
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>